From: Jakub Kicinski <kuba@kernel.org>
To: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: <davem@davemloft.net>, <shuah@kernel.org>, <dsahern@gmail.com>,
<netdev@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] selftest: net: remove meaningless help option
Date: Wed, 1 Dec 2021 17:52:51 -0800 [thread overview]
Message-ID: <20211201175251.00373dfe@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20211201111025.13834-3-lizhijian@cn.fujitsu.com>
On Wed, 1 Dec 2021 19:10:25 +0800 Li Zhijian wrote:
> $ ./fcnal-test.sh -t help
> Test names: help
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Not sure why the "help" test was added in the first place but could you
provide motivation for the patch in the commit message?
next prev parent reply other threads:[~2021-12-02 1:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 11:10 [PATCH 1/3] selftest: net: Correct case name Li Zhijian
2021-12-01 11:10 ` [PATCH 2/3] selftests: add option to list all avaliable tests Li Zhijian
2021-12-01 11:17 ` [PATCH v2 2/3] selftests: add option to list all available tests Li Zhijian
2021-12-01 11:22 ` [PATCH 2/3] selftests: add option to list all avaliable tests lizhijian
2021-12-02 1:48 ` Jakub Kicinski
2021-12-01 11:10 ` [PATCH 3/3] selftest: net: remove meaningless help option Li Zhijian
2021-12-02 1:52 ` Jakub Kicinski [this message]
2021-12-02 1:50 ` [PATCH 1/3] selftest: net: Correct case name Jakub Kicinski
2021-12-02 1:54 ` Jakub Kicinski
2021-12-02 2:19 ` Li, Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201175251.00373dfe@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).