From: Kees Cook <keescook@chromium.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: tglx@linutronix.de, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, shuah@kernel.org, joe@perches.com,
rostedt@goodmis.org, linux-spdx@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Goldwyn Rodrigues <rgoldwyn@suse.com>, Kuno Woudt <kuno@frob.nl>,
Richard Fontana <fontana@sharpeleven.org>,
copyleft-next@lists.fedorahosted.org,
Ciaran Farrell <Ciaran.Farrell@suse.com>,
Christopher De Nicolo <Christopher.DeNicolo@suse.com>,
Christoph Hellwig <hch@lst.de>, Jonathan Corbet <corbet@lwn.net>,
Thorsten Leemhuis <linux@leemhuis.info>
Subject: Re: [PATCH v10 2/2] testing: use the copyleft-next-0.3.1 SPDX tag
Date: Sat, 1 Oct 2022 07:58:06 -0700 [thread overview]
Message-ID: <202210010755.204FC88C@keescook> (raw)
In-Reply-To: <20220914060147.1934064-3-mcgrof@kernel.org>
On Tue, Sep 13, 2022 at 11:01:47PM -0700, Luis Chamberlain wrote:
> Two selftests drivers exist under the copyleft-next license.
> These drivers were added prior to SPDX practice taking full swing
> in the kernel. Now that we have an SPDX tag for copylef-next-0.3.1
nit: copylef -> copyleft
> documented, embrace it and remove the boiler plate.
>
> Cc: Goldwyn Rodrigues <rgoldwyn@suse.com>
> Cc: Kuno Woudt <kuno@frob.nl>
> Cc: Richard Fontana <fontana@sharpeleven.org>
> Cc: copyleft-next@lists.fedorahosted.org
> Cc: Ciaran Farrell <Ciaran.Farrell@suse.com>
> Cc: Christopher De Nicolo <Christopher.DeNicolo@suse.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Thorsten Leemhuis <linux@leemhuis.info>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
> lib/test_kmod.c | 12 +-----------
> lib/test_sysctl.c | 12 +-----------
> tools/testing/selftests/kmod/kmod.sh | 13 +------------
> tools/testing/selftests/sysctl/sysctl.sh | 12 +-----------
> 4 files changed, 4 insertions(+), 45 deletions(-)
Reviewed-by: Kees Cook <keescook@chromium.org>
Always nice to see more lines removed than added. :)
--
Kees Cook
next prev parent reply other threads:[~2022-10-01 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 6:01 [PATCH v10 0/2] SPDX: add copyleft-next-0.3.1 Luis Chamberlain
2022-09-14 6:01 ` [PATCH v10 1/2] LICENSES: Add the copyleft-next-0.3.1 license Luis Chamberlain
2022-10-01 15:08 ` Kees Cook
2022-09-14 6:01 ` [PATCH v10 2/2] testing: use the copyleft-next-0.3.1 SPDX tag Luis Chamberlain
2022-10-01 14:58 ` Kees Cook [this message]
2022-09-30 20:06 ` [PATCH v10 0/2] SPDX: add copyleft-next-0.3.1 Luis Chamberlain
2022-10-01 7:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202210010755.204FC88C@keescook \
--to=keescook@chromium.org \
--cc=Christopher.DeNicolo@suse.com \
--cc=Ciaran.Farrell@suse.com \
--cc=akpm@linux-foundation.org \
--cc=copyleft-next@lists.fedorahosted.org \
--cc=corbet@lwn.net \
--cc=fontana@sharpeleven.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=kuno@frob.nl \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=mcgrof@kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).