From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Cc: Petr Vorel <pvorel@suse.cz>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, Minchan Kim <minchan@kernel.org>,
Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Jens Axboe <axboe@kernel.dk>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Martin Doucha <mdoucha@suse.cz>,
Yang Xu <xuyang2018.jy@fujitsu.com>
Subject: [PATCH 1/1] zram01.sh: Workaround division by 0 on vfat on ppc64le
Date: Mon, 7 Nov 2022 20:11:36 +0100 [thread overview]
Message-ID: <20221107191136.18048-2-pvorel@suse.cz> (raw)
In-Reply-To: <20221107191136.18048-1-pvorel@suse.cz>
Repeatedly read /sys/block/zram*/mm_stat for 1 sec. This should fix bug
on ppc64le on stable kernels, where mem_used_total is often 0.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
.../kernel/device-drivers/zram/zram01.sh | 27 +++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
index 58d233f91..76a8ccab4 100755
--- a/testcases/kernel/device-drivers/zram/zram01.sh
+++ b/testcases/kernel/device-drivers/zram/zram01.sh
@@ -105,6 +105,26 @@ zram_mount()
tst_res TPASS "mount of zram device(s) succeeded"
}
+read_mem_used_total()
+{
+ echo $(awk '{print $3}' $1)
+}
+
+# Reads /sys/block/zram*/mm_stat until mem_used_total is not 0.
+loop_read_mem_used_total()
+{
+ local file="$1"
+ local mem_used_total
+
+ tst_res TINFO "$file"
+ cat $file >&2
+
+ mem_used_total=$(read_mem_used_total $file)
+ [ "$mem_used_total" -eq 0 ] && return 1
+
+ return 0
+}
+
zram_fill_fs()
{
local mem_used_total
@@ -133,9 +153,12 @@ zram_fill_fs()
continue
fi
- mem_used_total=`awk '{print $3}' "/sys/block/zram$i/mm_stat"`
+ TST_RETRY_FUNC "loop_read_mem_used_total /sys/block/zram$i/mm_stat" 0
+ mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
+ tst_res TINFO "mem_used_total: $mem_used_total"
+
v=$((100 * 1024 * $b / $mem_used_total))
- r=`echo "scale=2; $v / 100 " | bc`
+ r=$(echo "scale=2; $v / 100 " | bc)
if [ "$v" -lt 100 ]; then
tst_res TFAIL "compression ratio: $r:1"
--
2.38.0
next prev parent reply other threads:[~2022-11-07 19:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 19:11 [PATCH 0/1] Possible bug in zram on ppc64le on vfat Petr Vorel
2022-11-07 19:11 ` Petr Vorel [this message]
[not found] ` <CAEemH2fYv_=9UWdWB7VDiFOd8EC89qdCbxnPcTPAtGnkwLOYFg@mail.gmail.com>
2022-11-21 8:59 ` [LTP] [PATCH 1/1] zram01.sh: Workaround division by 0 on vfat on ppc64le Petr Vorel
2022-11-07 21:25 ` [PATCH 0/1] Possible bug in zram on ppc64le on vfat Minchan Kim
2022-11-07 21:47 ` Petr Vorel
2022-11-07 22:42 ` Petr Vorel
2022-11-08 1:05 ` Sergey Senozhatsky
2022-11-09 22:08 ` Petr Vorel
2022-11-10 23:04 ` Minchan Kim
2022-11-11 9:29 ` Petr Vorel
2022-11-10 14:29 ` Martin Doucha
2022-11-11 0:48 ` Sergey Senozhatsky
2022-11-21 9:41 ` Petr Vorel
2022-11-22 14:56 ` Martin Doucha
2022-11-22 15:07 ` Petr Vorel
2022-11-29 4:38 ` Sergey Senozhatsky
2023-05-02 15:23 ` Martin Doucha
2022-11-11 9:18 ` Petr Vorel
2023-08-04 6:37 ` Ian Wienand
2023-08-07 4:44 ` Ian Wienand
2023-08-07 5:19 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107191136.18048-2-pvorel@suse.cz \
--to=pvorel@suse.cz \
--cc=axboe@kernel.dk \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).