From: davidgow@google.com
To: Rae Moar <rmoar@google.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Stephen Boyd <sboyd@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Kees Cook <keescook@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Maxime Ripard <mripard@kernel.org>
Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-sound@vger.kernel.org,
David Gow <davidgow@google.com>
Subject: [PATCH 3/4] overflow: Replace fake root_device with kunit_device
Date: Tue, 05 Dec 2023 15:31:35 +0800 [thread overview]
Message-ID: <20231205-kunit_bus-v1-3-635036d3bc13@google.com> (raw)
In-Reply-To: <20231205-kunit_bus-v1-0-635036d3bc13@google.com>
Using struct root_device to create fake devices for tests is something
of a hack. The new struct kunit_device is meant for this purpose, so use
it instead.
Signed-off-by: David Gow <davidgow@google.com>
---
lib/overflow_kunit.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c
index 34db0b3aa502..91b03217c462 100644
--- a/lib/overflow_kunit.c
+++ b/lib/overflow_kunit.c
@@ -7,6 +7,7 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <kunit/test.h>
+#include <kunit/device.h>
#include <linux/device.h>
#include <linux/kernel.h>
#include <linux/mm.h>
@@ -618,7 +619,7 @@ static void overflow_allocation_test(struct kunit *test)
} while (0)
/* Create dummy device for devm_kmalloc()-family tests. */
- dev = root_device_register(device_name);
+ dev = kunit_device_register(test, device_name);
KUNIT_ASSERT_FALSE_MSG(test, IS_ERR(dev),
"Cannot register test device\n");
@@ -634,7 +635,7 @@ static void overflow_allocation_test(struct kunit *test)
check_allocation_overflow(devm_kmalloc);
check_allocation_overflow(devm_kzalloc);
- device_unregister(dev);
+ kunit_device_unregister(test, dev);
kunit_info(test, "%d allocation overflow tests finished\n", count);
#undef check_allocation_overflow
--
2.43.0.rc2.451.g8631bc7472-goog
next prev parent reply other threads:[~2023-12-05 7:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 7:31 [PATCH 0/4] kunit: Add helpers for creating test-managed devices davidgow
2023-12-05 7:31 ` [PATCH 1/4] kunit: Add APIs for managing devices davidgow
2023-12-05 8:30 ` Matti Vaittinen
2023-12-06 7:43 ` David Gow
2023-12-05 9:00 ` Maxime Ripard
2023-12-05 9:02 ` Amadeusz Sławiński
2023-12-05 13:53 ` kernel test robot
2023-12-05 14:59 ` kernel test robot
2023-12-05 15:10 ` kernel test robot
2023-12-05 16:05 ` kernel test robot
2023-12-05 17:30 ` Greg Kroah-Hartman
2023-12-06 7:44 ` David Gow
2023-12-07 2:29 ` Greg Kroah-Hartman
2023-12-05 7:31 ` [PATCH 2/4] fortify: test: Use kunit_device davidgow
2023-12-05 8:39 ` Matti Vaittinen
2023-12-06 21:07 ` Kees Cook
2023-12-08 7:38 ` David Gow
2023-12-05 7:31 ` davidgow [this message]
2023-12-05 8:46 ` [PATCH 3/4] overflow: Replace fake root_device with kunit_device Matti Vaittinen
2023-12-05 7:31 ` [PATCH 4/4] ASoC: topology: Replace fake root_device with kunit_device in tests davidgow
2023-12-05 9:02 ` Amadeusz Sławiński
2023-12-05 13:03 ` Mark Brown
2023-12-05 9:04 ` [PATCH] drm/tests: Switch to kunit devices Maxime Ripard
2023-12-06 16:31 ` kernel test robot
2023-12-06 16:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205-kunit_bus-v1-3-635036d3bc13@google.com \
--to=davidgow@google.com \
--cc=brendan.higgins@linux.dev \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=mripard@kernel.org \
--cc=perex@perex.cz \
--cc=rmoar@google.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).