From: Francis Laniel <flaniel@linux.microsoft.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Alban Crequy <alban.crequy@gmail.com>,
Alban Crequy <albancrequy@microsoft.com>,
Andrii Nakryiko <andrii@kernel.org>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-mm@kvack.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [RFC PATCH v1 1/2] maccess: fix writing offset in case of fault in strncpy_from_kernel_nofault()
Date: Wed, 09 Nov 2022 12:04:24 +0100 [thread overview]
Message-ID: <2655397.mvXUDI8C0e@pwmachine> (raw)
In-Reply-To: <20221108130551.85ad67b402582e3855418294@linux-foundation.org>
Hi.
Le mardi 8 novembre 2022, 22:05:51 CET Andrew Morton a écrit :
> On Tue, 8 Nov 2022 20:52:06 +0100 Francis Laniel
<flaniel@linux.microsoft.com> wrote:
> > From: Alban Crequy <albancrequy@microsoft.com>
> >
> > If a page fault occurs while copying the first byte, this function resets
> > one byte before dst.
> > As a consequence, an address could be modified and leaded to kernel
> > crashes if case the modified address was accessed later.
> >
> > Signed-off-by: Alban Crequy <albancrequy@microsoft.com>
> > Tested-by: Francis Laniel <flaniel@linux.microsoft.com>
>
> Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
>
> Please merge via the bpf tree.
>
> This looks potentially nasty. Fortunately only tracing code uses it,
> but I'm thinking it should have cc:stable and a Fixes:?
Thank you for the review!
Sorry, I thought to add stable list but forgot to add it when sending the
series...
I will sent a v2 with your review and without rfc tag to, among others,
stable.
next prev parent reply other threads:[~2022-11-09 11:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 19:52 [RFC PATCH v1 0/2] Fix offset when fault occurs in strncpy_from_kernel_nofault() Francis Laniel
2022-11-08 19:52 ` [RFC PATCH v1 1/2] maccess: fix writing offset in case of fault " Francis Laniel
2022-11-08 20:35 ` Yonghong Song
2022-11-08 20:38 ` Yonghong Song
2022-11-09 11:23 ` Alban Crequy
2022-11-09 16:09 ` Yonghong Song
2022-11-08 21:05 ` Andrew Morton
2022-11-09 11:04 ` Francis Laniel [this message]
2022-11-08 19:52 ` [RFC PATCH v1 2/2] selftests: bpf: add a test when bpf_probe_read_kernel_str() returns EFAULT Francis Laniel
2022-11-08 22:06 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2655397.mvXUDI8C0e@pwmachine \
--to=flaniel@linux.microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=alban.crequy@gmail.com \
--cc=albancrequy@microsoft.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).