On Thu, Apr 11, 2024 at 05:50:53PM +0200, Oleg Nesterov wrote: > On 04/11, Thomas Gleixner wrote: > > Grrr. Let me stare at this. > Damn ;) > Can't we just turn ksft_min_kernel_version() into > static inline int ksft_min_kernel_version(unsigned int min_major, > unsigned int min_minor) > { > #ifdef NOLIBC > return -1; > #else That'd probably work well enough here. I think it's reasonable for someone who wants to build a test that uses ksft_min_kernel_version() with nolibc to figure out how to implement it, right now it's not actually getting used with nolibc and just happens to be seen due to being in the same header. > Not sure what should check_timer_distribution() do in this case, to me > ksft_test_result_fail() is fine. I'd go with skip but yeah.