archive mirror
 help / color / mirror / Atom feed
From: shuah <>
To: Marcelo Henrique Cerri <>
Cc: "David S. Miller" <>,,,, shuah <>
Subject: Re: [PATCH] selftests/net: replace AF_MAX with INT_MAX in socket.c
Date: Tue, 17 Sep 2019 08:09:36 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20190917071222.6nfzmcxt4kxzgpki@gallifrey>

On 9/17/19 1:12 AM, Marcelo Henrique Cerri wrote:
> So the problem arises because the headers we have in userspace might
> be older and not match what we have in the kernel. In that case, the
> actual value of AF_MAX in the userspace headers might be a valid
> protocol family in the new kernel.
> That happens relatively often for us because we support different
> kernel versions at the same time in a given Ubuntu series.

Right. This is an evolving use-case for kselftest to make it easier to
run on distribution kernels.

> An alternative is to use the headers we have in the kernel tree, but I
> believe that might cause other issues.

Kselftest is tied to the kernel in such as way that you do need to use
the kernel headers to compile.

Do you run newer tests on older kernels? Where do you build them? What
I would like to see is fixing the test to run on older kernels and not
changing the tests to suit older kernel needs.

This definitely isn't a change that is good to make. We have to come
with a better way to solve this. Could you please send me the errors
you are seeing so I can help you find a better solution.

-- Shuah

  reply	other threads:[~2019-09-17 14:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 15:03 [PATCH] selftests/net: replace AF_MAX with INT_MAX in socket.c Marcelo Henrique Cerri
2019-09-16 16:09 ` shuah
2019-09-17  7:12   ` Marcelo Henrique Cerri
2019-09-17 14:09     ` shuah [this message]
2019-09-23  8:51 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).