Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config
@ 2020-05-22 11:36 Alan Maguire
  2020-05-22 11:36 ` [PATCH bpf 1/2] selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o Alan Maguire
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Alan Maguire @ 2020-05-22 11:36 UTC (permalink / raw)
  To: ast, daniel, andriin
  Cc: kafai, john.fastabend, kpsingh, shuah, sean, netdev, bpf,
	linux-kselftest, Alan Maguire

Selftests "config" file is intended to represent the config required
to run the tests; a few values are missing for the BPF selftests
and these can result in test failures due to missing helpers etc.
Add the missing values as they will help document the config needed
for a clean BPF selftests run.

Alan Maguire (2):
  selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o
  selftests/bpf: CONFIG_LIRC required for test_lirc_mode2.sh

 tools/testing/selftests/bpf/config | 2 ++
 1 file changed, 2 insertions(+)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH bpf 1/2] selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o
  2020-05-22 11:36 [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config Alan Maguire
@ 2020-05-22 11:36 ` Alan Maguire
  2020-05-22 11:36 ` [PATCH bpf 2/2] selftests/bpf: CONFIG_LIRC required for test_lirc_mode2.sh Alan Maguire
  2020-05-22 23:37 ` [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config Daniel Borkmann
  2 siblings, 0 replies; 4+ messages in thread
From: Alan Maguire @ 2020-05-22 11:36 UTC (permalink / raw)
  To: ast, daniel, andriin
  Cc: kafai, john.fastabend, kpsingh, shuah, sean, netdev, bpf,
	linux-kselftest, Alan Maguire

test_seg6_loop.o uses the helper bpf_lwt_seg6_adjust_srh();
it will not be present if CONFIG_IPV6_SEG6_BPF is not specified.

Fixes: b061017f8b4d ("selftests/bpf: add realistic loop tests")
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
 tools/testing/selftests/bpf/config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
index 60e3ae5..48e0585 100644
--- a/tools/testing/selftests/bpf/config
+++ b/tools/testing/selftests/bpf/config
@@ -25,6 +25,7 @@ CONFIG_XDP_SOCKETS=y
 CONFIG_FTRACE_SYSCALLS=y
 CONFIG_IPV6_TUNNEL=y
 CONFIG_IPV6_GRE=y
+CONFIG_IPV6_SEG6_BPF=y
 CONFIG_NET_FOU=m
 CONFIG_NET_FOU_IP_TUNNELS=y
 CONFIG_IPV6_FOU=m
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH bpf 2/2] selftests/bpf: CONFIG_LIRC required for test_lirc_mode2.sh
  2020-05-22 11:36 [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config Alan Maguire
  2020-05-22 11:36 ` [PATCH bpf 1/2] selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o Alan Maguire
@ 2020-05-22 11:36 ` Alan Maguire
  2020-05-22 23:37 ` [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config Daniel Borkmann
  2 siblings, 0 replies; 4+ messages in thread
From: Alan Maguire @ 2020-05-22 11:36 UTC (permalink / raw)
  To: ast, daniel, andriin
  Cc: kafai, john.fastabend, kpsingh, shuah, sean, netdev, bpf,
	linux-kselftest, Alan Maguire

test_lirc_mode2.sh assumes presence of /sys/class/rc/rc0/lirc*/uevent
which will not be present unless CONFIG_LIRC=y

Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program")
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
 tools/testing/selftests/bpf/config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
index 48e0585..2118e23 100644
--- a/tools/testing/selftests/bpf/config
+++ b/tools/testing/selftests/bpf/config
@@ -38,3 +38,4 @@ CONFIG_IPV6_SIT=m
 CONFIG_BPF_JIT=y
 CONFIG_BPF_LSM=y
 CONFIG_SECURITY=y
+CONFIG_LIRC=y
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config
  2020-05-22 11:36 [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config Alan Maguire
  2020-05-22 11:36 ` [PATCH bpf 1/2] selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o Alan Maguire
  2020-05-22 11:36 ` [PATCH bpf 2/2] selftests/bpf: CONFIG_LIRC required for test_lirc_mode2.sh Alan Maguire
@ 2020-05-22 23:37 ` Daniel Borkmann
  2 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2020-05-22 23:37 UTC (permalink / raw)
  To: Alan Maguire, ast, andriin
  Cc: kafai, john.fastabend, kpsingh, shuah, sean, netdev, bpf,
	linux-kselftest

On 5/22/20 1:36 PM, Alan Maguire wrote:
> Selftests "config" file is intended to represent the config required
> to run the tests; a few values are missing for the BPF selftests
> and these can result in test failures due to missing helpers etc.
> Add the missing values as they will help document the config needed
> for a clean BPF selftests run.
> 
> Alan Maguire (2):
>    selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o
>    selftests/bpf: CONFIG_LIRC required for test_lirc_mode2.sh
> 
>   tools/testing/selftests/bpf/config | 2 ++
>   1 file changed, 2 insertions(+)
> 

Applied to bpf-next, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 11:36 [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config Alan Maguire
2020-05-22 11:36 ` [PATCH bpf 1/2] selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o Alan Maguire
2020-05-22 11:36 ` [PATCH bpf 2/2] selftests/bpf: CONFIG_LIRC required for test_lirc_mode2.sh Alan Maguire
2020-05-22 23:37 ` [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config Daniel Borkmann

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git