From: shuah <shuah@kernel.org>
To: Eugeniu Rosca <erosca@de.adit-jv.com>
Cc: "George G. Davis" <george_davis@mentor.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Eugeniu Rosca <roscaeugeniu@gmail.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument
Date: Wed, 2 Oct 2019 13:48:37 -0600 [thread overview]
Message-ID: <2f1d360f-ee56-8d68-c66a-53604baf8907@kernel.org> (raw)
In-Reply-To: <20191002104101.GA6855@vmlxhi-102.adit-jv.com>
On 10/2/19 4:41 AM, Eugeniu Rosca wrote:
> Hi Shuah,
>
> On Tue, Oct 01, 2019 at 08:41:43PM +0000, patchwork-bot+linux-kselftest@kernel.org wrote:
>> Hello:
>>
>> This series was applied to shuah/linux-kselftest.git (refs/heads/fixes).
>>
>> On Tue, 17 Sep 2019 20:40:22 +0200 you wrote:
>>> From: "George G. Davis" <george_davis@mentor.com>
>>>
>>> The newly added optional file argument does not validate if the
>>> file is indeed a watchdog, e.g.:
>>>
>>> ./watchdog-test -f /dev/zero
>>> Watchdog Ticking Away!
>>>
>>> [...]
>>
>> Here is a summary with links:
>> - [v3,1/2] selftests: watchdog: Validate optional file argument
>> https://git.kernel.org/shuah/linux-kselftest/c/93c384f5d553bc4fdfb252b89ff378363ee05cee
>
> Could you please update the 'Fixes:' tag in the above commit to:
> Fixes: a4864a33f56caa ("selftests: watchdog: Add optional file argument")
>
> The warning in https://patchwork.kernel.org/patch/11149287/ clearly says
> that the fixed commit is from linux-next and it seems to have been
> updated before landing in mainline. TIA.
>
Thanks. My scripts didn't catch it for some reason. Fixed now.
-- Shuah
prev parent reply other threads:[~2019-10-02 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 18:40 [PATCH v3 1/2] selftests: watchdog: Validate optional file argument Eugeniu Rosca
2019-09-17 18:40 ` [PATCH v3 2/2] selftests: watchdog: Add command line option to show watchdog_info Eugeniu Rosca
2019-09-18 11:33 ` [PATCH v3 1/2] selftests: watchdog: Validate optional file argument Eugeniu Rosca
2019-09-18 21:05 ` shuah
2019-09-19 9:50 ` Eugeniu Rosca
[not found] ` <156996250317.31379.1299334144215961607.git-patchwork-notify@kernel.org>
2019-10-02 10:41 ` Eugeniu Rosca
2019-10-02 19:48 ` shuah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f1d360f-ee56-8d68-c66a-53604baf8907@kernel.org \
--to=shuah@kernel.org \
--cc=erosca@de.adit-jv.com \
--cc=george_davis@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=roscaeugeniu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).