From: Cristian Marussi <cristian.marussi@arm.com> To: Dave Martin <Dave.Martin@arm.com> Cc: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shuah@kernel.org, andreyknvl@google.com Subject: Re: [PATCH v3 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Date: Fri, 30 Aug 2019 16:11:14 +0100 Message-ID: <303594b8-9cb5-5271-0a10-6c9eec0fa6e8@arm.com> (raw) In-Reply-To: <20190813162633.GG10425@arm.com> On 13/08/2019 17:26, Dave Martin wrote: > On Fri, Aug 02, 2019 at 06:02:58PM +0100, Cristian Marussi wrote: >> Added a simple fake_sigreturn testcase which builds a ucontext_t > > Add Ok > >> with an anomalous additional fpsimd_context and place it onto the stack. >> Expects a SIGSEGV on test PASS. >> >> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> >> --- >> .../arm64/signal/testcases/.gitignore | 1 + >> .../fake_sigreturn_duplicated_fpsimd.c | 62 +++++++++++++++++++ >> 2 files changed, 63 insertions(+) >> create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> >> diff --git a/tools/testing/selftests/arm64/signal/testcases/.gitignore b/tools/testing/selftests/arm64/signal/testcases/.gitignore >> index 17d1c5e73319..94f9baaf638c 100644 >> --- a/tools/testing/selftests/arm64/signal/testcases/.gitignore >> +++ b/tools/testing/selftests/arm64/signal/testcases/.gitignore >> @@ -7,3 +7,4 @@ mangle_pstate_ssbs_regs >> fake_sigreturn_bad_magic >> fake_sigreturn_bad_size_for_magic0 >> fake_sigreturn_missing_fpsimd >> +fake_sigreturn_duplicated_fpsimd >> diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> new file mode 100644 >> index 000000000000..09af7a0f8776 >> --- /dev/null >> +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> @@ -0,0 +1,62 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* Copyright (C) 2019 ARM Limited */ >> + > > signal.h? Ok > >> +#include <stdio.h> >> +#include <ucontext.h> >> + >> +#include "test_signals_utils.h" >> +#include "testcases.h" >> + >> +struct fake_sigframe sf; >> + >> +static int fake_sigreturn_duplicated_fpsimd_run(struct tdescr *td, >> + siginfo_t *si, ucontext_t *uc) >> +{ >> + size_t resv_sz, offset; >> + struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head; >> + >> + /* just to fill the ucontext_t with something real */ >> + if (!get_current_context(td, &sf.uc)) >> + return 1; >> + >> + resv_sz = GET_SF_RESV_SIZE(sf); >> + /* >> + * find the terminator, preserving existing headers >> + * and verify amount of spare room in __reserved area. >> + */ >> + head = get_terminator(shead, resv_sz, &offset); >> + /* >> + * try stripping extra_context header when low on space: >> + * we need at least space for one additional fpsimd_context >> + */ >> + if (head && resv_sz - offset < sizeof(struct fpsimd_context)) { >> + fprintf(stderr, "Low on space:%zd. Discarding extra_context.\n", >> + resv_sz - offset); >> + head = get_header(shead, EXTRA_MAGIC, resv_sz, &offset); >> + } >> + >> + /* just give up and timeout if still not enough space */ >> + if (head && >> + resv_sz - offset >= sizeof(struct fpsimd_context) + HDR_SZ) { >> + fprintf(stderr, "Mangling template header. Spare space:%zd\n", >> + resv_sz - offset); >> + /* Add a spurios fpsimd_context */ >> + head->magic = FPSIMD_MAGIC; >> + head->size = sizeof(struct fpsimd_context); >> + /* and terminate */ >> + write_terminator_record(GET_RESV_NEXT_HEAD(head)); >> + >> + ASSERT_BAD_CONTEXT(&sf.uc); >> + fake_sigreturn(&sf, sizeof(sf), 16); >> + } >> + >> + return 1; >> +} > I'll convert to use new helper get_starting_head() to make space in __reserved. Cheers Cristian > [...] > > Otherwise looks ok. > > Cheers > ---Dave >
next prev parent reply index Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-02 17:02 [PATCH v3 00/11] Add arm64/signal initial kselftest support Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 01/11] kselftest: arm64: introduce new boilerplate code Cristian Marussi 2019-08-13 16:23 ` Dave Martin 2019-08-27 12:14 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 02/11] kselftest: arm64: adds first test and common utils Cristian Marussi 2019-08-06 15:50 ` Cristian Marussi 2019-08-07 15:42 ` Cristian Marussi 2019-08-09 10:54 ` Cristian Marussi 2019-08-09 11:16 ` Dave Martin 2019-08-09 12:20 ` Cristian Marussi 2019-08-09 12:32 ` Dave Martin 2019-08-12 12:43 ` Amit Kachhap 2019-08-13 13:22 ` Cristian Marussi 2019-08-14 10:22 ` Amit Kachhap 2019-08-27 14:24 ` Cristian Marussi 2019-08-13 16:24 ` Dave Martin 2019-08-28 17:34 ` Cristian Marussi 2019-09-03 15:34 ` Dave Martin 2019-09-03 16:08 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 03/11] kselftest: arm64: mangle_pstate_invalid_daif_bits Cristian Marussi 2019-08-13 16:24 ` Dave Martin 2019-08-29 10:19 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 04/11] kselftest: arm64: mangle_pstate_invalid_mode_el Cristian Marussi 2019-08-13 16:24 ` Dave Martin 2019-08-29 11:50 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 05/11] kselftest: arm64: mangle_pstate_ssbs_regs Cristian Marussi 2019-08-13 16:25 ` Dave Martin 2019-08-29 15:35 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 06/11] kselftest: arm64: fake_sigreturn_bad_magic Cristian Marussi 2019-08-13 16:25 ` Dave Martin 2019-08-30 14:29 ` Cristian Marussi 2019-09-04 10:05 ` Dave Martin 2019-09-04 10:37 ` Cristian Marussi 2019-09-04 10:47 ` Dave Martin 2019-08-02 17:02 ` [PATCH v3 07/11] kselftest: arm64: fake_sigreturn_bad_size_for_magic0 Cristian Marussi 2019-08-13 16:25 ` Dave Martin 2019-08-30 14:49 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 08/11] kselftest: arm64: fake_sigreturn_missing_fpsimd Cristian Marussi 2019-08-13 16:26 ` Dave Martin 2019-08-30 14:55 ` Cristian Marussi 2019-08-02 17:02 ` [PATCH v3 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Cristian Marussi 2019-08-13 16:26 ` Dave Martin 2019-08-30 15:11 ` Cristian Marussi [this message] 2019-08-02 17:02 ` [PATCH v3 10/11] kselftest: arm64: fake_sigreturn_bad_size Cristian Marussi 2019-08-13 16:26 ` Dave Martin 2019-08-30 15:21 ` Cristian Marussi 2019-08-02 17:03 ` [PATCH v3 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp Cristian Marussi 2019-08-07 16:04 ` Cristian Marussi 2019-08-13 16:28 ` Dave Martin 2019-08-30 15:22 ` Cristian Marussi 2019-08-13 16:27 ` Dave Martin 2019-08-30 16:33 ` Cristian Marussi 2019-08-13 16:22 ` [PATCH v3 00/11] Add arm64/signal initial kselftest support Dave Martin 2019-08-30 16:40 ` Cristian Marussi 2019-09-02 10:53 ` Dave Martin 2019-09-02 11:30 ` Cristian Marussi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=303594b8-9cb5-5271-0a10-6c9eec0fa6e8@arm.com \ --to=cristian.marussi@arm.com \ --cc=Dave.Martin@arm.com \ --cc=andreyknvl@google.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=shuah@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-kselftest Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \ linux-kselftest@vger.kernel.org public-inbox-index linux-kselftest Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest AGPL code for this site: git clone https://public-inbox.org/public-inbox.git