linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Stefano Brivio <sbrivio@redhat.com>,
	Veronika Kabatova <vkabatov@redhat.com>
Cc: linux-kselftest@vger.kernel.org, shuah <shuah@kernel.org>
Subject: Re: [PATCH v2] selftests: introduce gen_tar Makefile target
Date: Tue, 19 May 2020 16:16:40 -0600	[thread overview]
Message-ID: <35755630-2653-719d-5684-7cf7cc86fd2b@kernel.org> (raw)
In-Reply-To: <20200519225722.49e4d067@redhat.com>

On 5/19/20 2:57 PM, Stefano Brivio wrote:
> On Tue, 19 May 2020 22:00:45 +0200
> Veronika Kabatova <vkabatov@redhat.com> wrote:
> 
>> The gen_kselftest_tar.sh always packages *all* selftests and doesn't
>> pass along any variables to `make install` to influence what should be
>> built. This can result in an early error on the command line ("Unknown
>> tarball format TARGETS=XXX"), or unexpected test failures as the
>> tarball contains tests people wanted to skip on purpose.
>>
>> Since the makefile already contains all the logic, we can add a target
>> for packaging. Keep the default .gz target the script uses, and actually
>> extend the supported formats by using tar's autodetection.
>>
>> To not break current workflows, keep the gen_kselftest_tar.sh script as
>> it is, with an added suggestion to use the makefile target instead.
>>
>> Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> 
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> 

Applied to

git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
for Linux 5.8-rc1.

thanks,
-- Shuah

      reply	other threads:[~2020-05-19 22:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 20:00 [PATCH v2] selftests: introduce gen_tar Makefile target Veronika Kabatova
2020-05-19 20:57 ` Stefano Brivio
2020-05-19 22:16   ` shuah [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35755630-2653-719d-5684-7cf7cc86fd2b@kernel.org \
    --to=shuah@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=sbrivio@redhat.com \
    --cc=vkabatov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).