linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: linux-kselftest@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, shuah@kernel.org,
	amit.kachhap@arm.com, andreyknvl@google.com
Subject: Re: [PATCH v8 02/12] kselftest: arm64: mangle_pstate_invalid_compat_toggle and common utils
Date: Wed, 9 Oct 2019 12:55:33 +0100	[thread overview]
Message-ID: <38e73559-ad80-d05a-32ca-ac763ee648bb@arm.com> (raw)
In-Reply-To: <20191009111848.GB27757@arm.com>

On 09/10/2019 12:18, Dave Martin wrote:
> On Wed, Oct 09, 2019 at 09:26:01AM +0100, Cristian Marussi wrote:
>> Add some arm64/signal specific boilerplate and utility code to help
>> further testcases' development.
>>
>> Introduce also one simple testcase mangle_pstate_invalid_compat_toggle
>> and some related helpers: it is a simple mangle testcase which messes
>> with the ucontext_t from within the signal handler, trying to toggle
>> PSTATE state bits to switch the system between 32bit/64bit execution
>> state. Expects SIGSEGV on test PASS.
>>
>> Reviewed-by: Dave Martin <Dave.Martin@arm.com>
>> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
>> ---
>> v7 --> v8
>> - removed unused SSBS_SYSREG
> 
> [...]
> 
>> diff --git a/tools/testing/selftests/arm64/signal/.gitignore b/tools/testing/selftests/arm64/signal/.gitignore
>> new file mode 100644
>> index 000000000000..e5aeae45febb
>> --- /dev/null
>> +++ b/tools/testing/selftests/arm64/signal/.gitignore
>> @@ -0,0 +1,3 @@
>> +!*.[ch]
>> +mangle_*
>> +fake_sigreturn_*
> 
> I think the !*.[ch] line needs to come last.
> 
> Re-including *.[ch] on the first line has no effect because no files
> have been excluded yet.
> 
> (This looks like it was my mistake when I originally suggested using
> wildcards here -- apologies for that!)
> 
> I'm happy for you to keey my Reviewed-by on that change.
> 

Moved to last in v9

Cristian
> [...]
> 
> Cheers
> ---Dave
> 


  reply	other threads:[~2019-10-09 11:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09  8:25 [PATCH v8 00/12] Add arm64/signal initial kselftest support Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 01/12] kselftest: arm64: extend toplevel skeleton Makefile Cristian Marussi
2019-10-09 11:15   ` Dave Martin
2019-10-09 11:52     ` Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 02/12] kselftest: arm64: mangle_pstate_invalid_compat_toggle and common utils Cristian Marussi
2019-10-09 11:18   ` Dave Martin
2019-10-09 11:55     ` Cristian Marussi [this message]
2019-10-09  8:26 ` [PATCH v8 03/12] kselftest: arm64: mangle_pstate_invalid_daif_bits Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 04/12] kselftest: arm64: mangle_pstate_invalid_mode_el[123][ht] Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 05/12] kselftest: arm64: extend test_init functionalities Cristian Marussi
2019-10-09 11:32   ` Dave Martin
2019-10-09 11:57     ` Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 06/12] kselftest: arm64: add helper get_current_context Cristian Marussi
2019-10-09 11:32   ` Dave Martin
2019-10-09 11:57     ` Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 07/12] kselftest: arm64: fake_sigreturn_bad_magic Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 08/12] kselftest: arm64: fake_sigreturn_bad_size_for_magic0 Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 09/12] kselftest: arm64: fake_sigreturn_missing_fpsimd Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 10/12] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 11/12] kselftest: arm64: fake_sigreturn_bad_size Cristian Marussi
2019-10-09  8:26 ` [PATCH v8 12/12] kselftest: arm64: fake_sigreturn_misaligned_sp Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38e73559-ad80-d05a-32ca-ac763ee648bb@arm.com \
    --to=cristian.marussi@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=amit.kachhap@arm.com \
    --cc=andreyknvl@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).