From: Frank Rowand <frowand.list@gmail.com>
To: Daniel Latypov <dlatypov@google.com>, Rae Moar <rmoar@google.com>
Cc: davidgow@google.com, skhan@linuxfoundation.org,
keescook@chromium.org, Tim.Bird@sony.com,
brendanhiggins@google.com, corbet@lwn.net,
guillaume.tucker@collabora.com, kernelci@lists.linux.dev,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [KTAP V2 PATCH] ktap_v2: add recognized test name line
Date: Sun, 26 Mar 2023 21:44:30 -0500 [thread overview]
Message-ID: <3a4ed4a0-5694-ba59-a141-26e37576ff67@gmail.com> (raw)
In-Reply-To: <CAGS_qxp2u3F4abmYgN+XwCG8CJN37NSqWSC===SWLCjZG8HYBw@mail.gmail.com>
On 3/20/23 14:21, Daniel Latypov wrote:
> On Thu, Mar 16, 2023 at 3:59 PM Rae Moar <rmoar@google.com> wrote:
>>
>> Add recognition of the test name line ("# Subtest: <name>") to the KTAP v2
>> spec.
>>
>> The purpose of this line is to declare the name of a test before its
>> results. This functionality is especially useful when trying to parse test
>> results incrementally and when interpretting results after a crash.
>>
>> This line is already compliant with KTAP v1 as it is interpretted as a
>
> minor nit for if there's a v2, s/interprett/interpret (here and above)
>
> Also, I want to elaborate on the previous paragraph a bit more, in
> case the motivation isn't clear.
> The problem with TAP and KTAP as-is is that the name of a test case is
> only known *after* it completes.
>
> So the scenario being referred to is
>
> KTAP version 1
> 1..1
> <lots of output>
> <kernel crash, no more output>
>
> It would be nice if parsers could report "test FOO caused a crash" as
> opposed to "the first test case caused a crash, good luck figuring out
> which one that was"
>
> Daniel
It would be useful to take some of the motivation explanation from TAP14,
which says (everything to the end of this email):
Commented Subtests are encouraged, as they provide the following benefits:
Easier for humans to read. For example:
TAP version 14
1..1
ok 1 - hmm, what level is this?
vs:
TAP version 14
# Subtest: level 1
# Subtest: level 2
# Subtest: level 3
1..1
ok 1 - clearly level 3
Additional strictness around matching the Test Point description to Subtest Name can catch errors and detect accidentally interleaved output.
next prev parent reply other threads:[~2023-03-27 2:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 22:59 [KTAP V2 PATCH] ktap_v2: add recognized test name line Rae Moar
2023-03-20 19:21 ` Daniel Latypov
2023-03-27 2:44 ` Frank Rowand [this message]
2023-03-28 21:08 ` Rae Moar
2023-03-27 2:41 ` Frank Rowand
2023-03-29 18:34 ` Rae Moar
2023-03-31 20:00 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a4ed4a0-5694-ba59-a141-26e37576ff67@gmail.com \
--to=frowand.list@gmail.com \
--cc=Tim.Bird@sony.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=guillaume.tucker@collabora.com \
--cc=keescook@chromium.org \
--cc=kernelci@lists.linux.dev \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmoar@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).