* [PATCH] Removing a duplicate condition.
@ 2020-02-11 11:32 Isaac Young
2020-02-11 15:08 ` Alexei Starovoitov
2020-02-11 15:19 ` shuah
0 siblings, 2 replies; 3+ messages in thread
From: Isaac Young @ 2020-02-11 11:32 UTC (permalink / raw)
To: shuah, linux-kselftest, linux-kernel
Signed-off-by: Isaac Young <isaac.young5@gmail.com>
---
tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
index 098bcae5f827..0954c7a8aa08 100644
--- a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
+++ b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
@@ -823,7 +823,7 @@ void test_select_reuseport(void)
saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
- if (saved_tcp_syncookie < 0 || saved_tcp_syncookie < 0)
+ if (saved_tcp_syncookie < 0)
goto out;
if (enable_fastopen())
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Removing a duplicate condition.
2020-02-11 11:32 [PATCH] Removing a duplicate condition Isaac Young
@ 2020-02-11 15:08 ` Alexei Starovoitov
2020-02-11 15:19 ` shuah
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2020-02-11 15:08 UTC (permalink / raw)
To: Isaac Young; +Cc: Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK, LKML
On Tue, Feb 11, 2020 at 5:26 AM Isaac Young <isaac.young5@gmail.com> wrote:
>
> Signed-off-by: Isaac Young <isaac.young5@gmail.com>
> ---
> tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> index 098bcae5f827..0954c7a8aa08 100644
> --- a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> +++ b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> @@ -823,7 +823,7 @@ void test_select_reuseport(void)
>
> saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
> saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
> - if (saved_tcp_syncookie < 0 || saved_tcp_syncookie < 0)
> + if (saved_tcp_syncookie < 0)
> goto out;
please resend this patch to bpf@vger and cc maintainers.
Also see bpf_devel_QA.rst
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Removing a duplicate condition.
2020-02-11 11:32 [PATCH] Removing a duplicate condition Isaac Young
2020-02-11 15:08 ` Alexei Starovoitov
@ 2020-02-11 15:19 ` shuah
1 sibling, 0 replies; 3+ messages in thread
From: shuah @ 2020-02-11 15:19 UTC (permalink / raw)
To: Isaac Young, linux-kselftest, linux-kernel, shuah
Please include subsystem and test name in the subject line.
On 2/11/20 4:32 AM, Isaac Young wrote:
> Signed-off-by: Isaac Young <isaac.young5@gmail.com>
Missing commit log
> ---
> tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> index 098bcae5f827..0954c7a8aa08 100644
> --- a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> +++ b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> @@ -823,7 +823,7 @@ void test_select_reuseport(void)
>
> saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
> saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
> - if (saved_tcp_syncookie < 0 || saved_tcp_syncookie < 0)
This might not be the right fix. I think the check should be
if (saved_tcp_fo < 0 || saved_tcp_syncookie < 0)
at least makes the most sense based on the code.
> + if (saved_tcp_syncookie < 0)
> goto out;
>
> if (enable_fastopen())
>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-11 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 11:32 [PATCH] Removing a duplicate condition Isaac Young
2020-02-11 15:08 ` Alexei Starovoitov
2020-02-11 15:19 ` shuah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).