From: Eugene Syromiatnikov <esyr@redhat.com> To: linux-kernel@vger.kernel.org, Christian Brauner <christian@brauner.io>, Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org Cc: Adrian Reber <areber@redhat.com> Subject: [PATCH 3/6] selftests/clone3: use uint64_t for flags parameter Date: Tue, 10 Sep 2019 13:03:25 +0100 Message-ID: <3f7bd9f0446360f90f12b9e9d3af1de2f5133a81.1568116761.git.esyr@redhat.com> (raw) In-Reply-To: <cover.1568116761.git.esyr@redhat.com> Flags parameter in both userspace and kernel clone args is 64-bit wide, there's little reason to have it signed and 32-bit in tests. * tools/testing/selftests/clone3/clone3.c: Include <inttypes.h> and <stdint.h>. (call_clone3): Change flags parameter type from int to uint64_t. (test_clone3): Change flags parameter type from int to uint64_t; change the format string that prints it accordingly. Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com> --- tools/testing/selftests/clone3/clone3.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c index 4f23a0c..1746a9b 100644 --- a/tools/testing/selftests/clone3/clone3.c +++ b/tools/testing/selftests/clone3/clone3.c @@ -4,8 +4,10 @@ #define _GNU_SOURCE #include <errno.h> +#include <inttypes.h> #include <linux/types.h> #include <linux/sched.h> +#include <stdint.h> #include <stdio.h> #include <stdlib.h> #include <sys/syscall.h> @@ -36,7 +38,7 @@ static pid_t raw_clone(struct clone_args *args, size_t size) return syscall(__NR_clone3, args, size); } -static int call_clone3(int flags, size_t size, enum test_mode test_mode) +static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode) { struct clone_args args = {0}; pid_t ppid = -1; @@ -102,12 +104,13 @@ static int call_clone3(int flags, size_t size, enum test_mode test_mode) return 0; } -static int test_clone3(int flags, size_t size, int expected, +static int test_clone3(uint64_t flags, size_t size, int expected, enum test_mode test_mode) { int ret; - ksft_print_msg("[%d] Trying clone3() with flags 0x%x (size %d)\n", + ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %d)" + "\n", getpid(), flags, size); ret = call_clone3(flags, size, test_mode); ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n", -- 2.1.4
next prev parent reply index Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-10 12:02 [PATCH 0/6] Update clone3 self-tests Eugene Syromiatnikov 2019-09-10 12:03 ` [PATCH 1/6] selftests/clone3: convert test modes into an enum Eugene Syromiatnikov 2019-09-16 16:28 ` shuah 2019-09-10 12:03 ` [PATCH 2/6] selftests/clone3: add a check for invalid exit_signal Eugene Syromiatnikov 2019-09-16 16:37 ` shuah 2019-09-10 12:03 ` Eugene Syromiatnikov [this message] 2019-09-16 16:40 ` [PATCH 3/6] selftests/clone3: use uint64_t for flags parameter shuah 2019-09-10 12:03 ` [PATCH 4/6] selftests/clone3: fix up format strings Eugene Syromiatnikov 2019-09-16 16:41 ` shuah 2019-09-10 12:03 ` [PATCH 5/6] selftests/clone3: enable clone3 self-tests on all architectures Eugene Syromiatnikov 2019-09-16 16:44 ` shuah 2019-09-10 12:03 ` [PATCH 6/6] selftests: add clone3 to TARGETS Eugene Syromiatnikov 2019-09-16 16:48 ` shuah
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3f7bd9f0446360f90f12b9e9d3af1de2f5133a81.1568116761.git.esyr@redhat.com \ --to=esyr@redhat.com \ --cc=areber@redhat.com \ --cc=christian@brauner.io \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=shuah@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-kselftest Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \ linux-kselftest@vger.kernel.org public-inbox-index linux-kselftest Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest AGPL code for this site: git clone https://public-inbox.org/public-inbox.git