Linux-kselftest Archive on lore.kernel.org
 help / color / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: "Bird, Tim" <Tim.Bird@sony.com>, "shuah@kernel.org" <shuah@kernel.org>
Cc: "linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: Fix memfd to support relocatable build (O=objdir)
Date: Thu, 26 Mar 2020 16:33:45 -0600
Message-ID: <3fa8af77-4b4b-c1e2-2467-fb7b9adb3f66@linuxfoundation.org> (raw)
In-Reply-To: <MWHPR13MB08955F0F8C5D0B07CA86DA92FDCF0@MWHPR13MB0895.namprd13.prod.outlook.com>

On 3/26/20 4:23 PM, Bird, Tim wrote:
>> -----Original Message-----
>> From: Shuah Khan
>>
>> Fix memfd to support relocatable build (O=objdir). This calls out
>> source files necessary to build tests and simplfies the dependency
>> enforcement.
>>
>> Tested the following:
>>
>> Note that cross-build for fuse_mnt has dependency on -lfuse.
>>
>> make all
>> make clean
>> make kselftest-install O=/arm64_build/ ARCH=arm64 HOSTCC=gcc \
>> CROSS_COMPILE=aarch64-linux-gnu- TARGETS=memfd
>>
>> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
>> ---
>>   tools/testing/selftests/memfd/Makefile | 9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile
>> index 53a848109f7b..0a15f9e23431 100644
>> --- a/tools/testing/selftests/memfd/Makefile
>> +++ b/tools/testing/selftests/memfd/Makefile
>> @@ -4,9 +4,8 @@ CFLAGS += -I../../../../include/uapi/
>>   CFLAGS += -I../../../../include/
>>   CFLAGS += -I../../../../usr/include/
>>
>> -TEST_GEN_PROGS := memfd_test
>> +TEST_GEN_PROGS := memfd_test fuse_test fuse_mnt
>>   TEST_PROGS := run_fuse_test.sh run_hugetlbfs_test.sh
>> -TEST_GEN_FILES := fuse_mnt fuse_test
>>
>>   fuse_mnt.o: CFLAGS += $(shell pkg-config fuse --cflags)
>>
>> @@ -14,7 +13,7 @@ include ../lib.mk
>>
>>   $(OUTPUT)/fuse_mnt: LDLIBS += $(shell pkg-config fuse --libs)
> 
> Sorry to interject here.  This comment doesn't have to do with this patch,
> but the above line is problematical for cross-compilation.
> $(shell pkg-config fuse --libs) will use pkg-config from the host
> machine, and may produce something different from what's
> installed on the target.  For most enterprise and desktop systems
> library paths for are mostly standardized.  The effect is that if
> you're doing 'simple' embedded, the pkg-config output on the
> host will match that of the target board.  However, in some
> embedded products the partition and filesystem setups are
> often quite complicated (e.g. I recently worked on a TV set with 14
> partitions) and things are not in the locations preferred by the
> Filesystem Hierarchy Standard.
> 
> When cross-compiling for our products, we tend to use the pkg-config
> from the filesystem of the target (a copy of which is on the host), rather
> than the host's pkg-config.
> 
Thanks for bringing attention to the issue. This is an existing
issue. Thankfully this is one of the two tests that use pkg-config.

The problem is limited to just two tests that are included in the
Makefile TARGETS.

> I don't have a board in my test lab where this shows up, nor a
> proposed solution at the moment, but I'm just mentioning it as a
> potential host-environment build contamination issue.  Maybe I
> should start keeping a list, and start thinking of possible solutions for
> more of these types of issues.


Thanks for bringing attention to the issue. I will keep an eye out for
this kind of usage during my reviews.

> 
> P.S. I'd ignore this issue for approving this patch.  I'm just bringing
> it up as a red flag for future work.

Thanks. This is an existing problem that can be addressed in a separate
page.

thanks,
-- Shuah

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 23:17 Shuah Khan
2020-03-26 22:23 ` Bird, Tim
2020-03-26 22:33   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fa8af77-4b4b-c1e2-2467-fb7b9adb3f66@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=Tim.Bird@sony.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-kselftest Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kselftest/0 linux-kselftest/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kselftest linux-kselftest/ https://lore.kernel.org/linux-kselftest \
		linux-kselftest@vger.kernel.org
	public-inbox-index linux-kselftest

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kselftest


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git