From: shuah <shuah@kernel.org>
To: Eugeniu Rosca <erosca@de.adit-jv.com>
Cc: Eugeniu Rosca <roscaeugeniu@gmail.com>,
"George G. Davis" <george_davis@mentor.com>,
Jerry Hoemann <jerry.hoemann@hpe.com>,
Colin Ian King <colin.king@canonical.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah <shuah@kernel.org>
Subject: Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument
Date: Wed, 18 Sep 2019 15:05:33 -0600 [thread overview]
Message-ID: <41ad241a-1c9d-7e20-3cb1-84bf42ec6989@kernel.org> (raw)
In-Reply-To: <20190918113348.GA23977@vmlxhi-102.adit-jv.com>
On 9/18/19 5:33 AM, Eugeniu Rosca wrote:
> Hi Shuah,
>
> On Tue, Sep 17, 2019 at 08:40:22PM +0200, Eugeniu Rosca wrote:
>> From: "George G. Davis" <george_davis@mentor.com>
>>
>> The newly added optional file argument does not validate if the
>> file is indeed a watchdog, e.g.:
>>
>> ./watchdog-test -f /dev/zero
>> Watchdog Ticking Away!
>>
>> Fix it by confirming that the WDIOC_GETSUPPORT ioctl succeeds.
>>
>> Fixes: c3f2490d6e9257 ("selftests: watchdog: Add optional file argument")
>> Reported-by: Eugeniu Rosca <erosca@de.adit-jv.com>
>> Signed-off-by: George G. Davis <george_davis@mentor.com>
>> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
>> ---
>> v3:
>> - Used v1 as starting point and simplified commit description
>> - Added Fixes tag (WARNING: commit id is from linux-next!)
>> - No change in the contents
>> - Applied cleanly to the same base as used in [v1]
>
> Can we have your confirmation the patches look fine now?
>
Hi Eugeniu,
They both look good to me. I will apply these patches once the merge
window closes or when my first pull request to Linus clears.
You will see a notification when I apply them to kselftest tree.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-09-18 21:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 18:40 [PATCH v3 1/2] selftests: watchdog: Validate optional file argument Eugeniu Rosca
2019-09-17 18:40 ` [PATCH v3 2/2] selftests: watchdog: Add command line option to show watchdog_info Eugeniu Rosca
2019-09-18 11:33 ` [PATCH v3 1/2] selftests: watchdog: Validate optional file argument Eugeniu Rosca
2019-09-18 21:05 ` shuah [this message]
2019-09-19 9:50 ` Eugeniu Rosca
[not found] ` <156996250317.31379.1299334144215961607.git-patchwork-notify@kernel.org>
2019-10-02 10:41 ` Eugeniu Rosca
2019-10-02 19:48 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ad241a-1c9d-7e20-3cb1-84bf42ec6989@kernel.org \
--to=shuah@kernel.org \
--cc=colin.king@canonical.com \
--cc=erosca@de.adit-jv.com \
--cc=george_davis@mentor.com \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=roscaeugeniu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).