From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774D6C4CEC4 for ; Wed, 18 Sep 2019 21:05:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D3E821897 for ; Wed, 18 Sep 2019 21:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568840746; bh=8S3vx3u2VKiDDLEVuHlbz2yPV0iiD4FMZukr1aW2DL4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=Tb4JmI81KeTzlgBjKH1ACvFawzuh7Hcy/PWhlRcVL/5v0H/h/sHt2lMyCi7kWLpLo I0OVeLhGXCQiX2XLN+Xw0zXEck4E00O5bpSuXQ8yhjAatL6JYqJ0dzVZbiKHCM7Cef 6YtHfM7bMyB794fUM9TajMxFyDrBBCrKj7vn7t0E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387733AbfIRVFq (ORCPT ); Wed, 18 Sep 2019 17:05:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:56662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387661AbfIRVFp (ORCPT ); Wed, 18 Sep 2019 17:05:45 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39FC020665; Wed, 18 Sep 2019 21:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568840745; bh=8S3vx3u2VKiDDLEVuHlbz2yPV0iiD4FMZukr1aW2DL4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=T1r58jALxX7MEJEJgZT8tNCbextz61Tl9oQnUcup5o7dKpqDPlYnxSnGJJiX66cyg mjqMew8q+A2+TihEh8gpz2+XsJ4XnsUwO01TIctrCeOdjem7J3Oo8UHXtw1euInTWW i67fLnR4BNzHIOFXv8mxEYcSd76um34/aqcl1qfI= Subject: Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument To: Eugeniu Rosca Cc: Eugeniu Rosca , "George G. Davis" , Jerry Hoemann , Colin Ian King , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, shuah References: <20190917184023.16701-1-erosca@de.adit-jv.com> <20190918113348.GA23977@vmlxhi-102.adit-jv.com> From: shuah Message-ID: <41ad241a-1c9d-7e20-3cb1-84bf42ec6989@kernel.org> Date: Wed, 18 Sep 2019 15:05:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190918113348.GA23977@vmlxhi-102.adit-jv.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 9/18/19 5:33 AM, Eugeniu Rosca wrote: > Hi Shuah, > > On Tue, Sep 17, 2019 at 08:40:22PM +0200, Eugeniu Rosca wrote: >> From: "George G. Davis" >> >> The newly added optional file argument does not validate if the >> file is indeed a watchdog, e.g.: >> >> ./watchdog-test -f /dev/zero >> Watchdog Ticking Away! >> >> Fix it by confirming that the WDIOC_GETSUPPORT ioctl succeeds. >> >> Fixes: c3f2490d6e9257 ("selftests: watchdog: Add optional file argument") >> Reported-by: Eugeniu Rosca >> Signed-off-by: George G. Davis >> Signed-off-by: Eugeniu Rosca >> --- >> v3: >> - Used v1 as starting point and simplified commit description >> - Added Fixes tag (WARNING: commit id is from linux-next!) >> - No change in the contents >> - Applied cleanly to the same base as used in [v1] > > Can we have your confirmation the patches look fine now? > Hi Eugeniu, They both look good to me. I will apply these patches once the merge window closes or when my first pull request to Linus clears. You will see a notification when I apply them to kselftest tree. thanks, -- Shuah