From: Yonghong Song <yhs@fb.com>
To: Hao Luo <haoluo@google.com>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<clang-built-linux@googlegroups.com>,
<linux-kselftest@vger.kernel.org>
Cc: <sdf@google.com>, Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: Switch test_vmlinux to use hrtimer_range_start_ns.
Date: Tue, 30 Jun 2020 13:36:57 -0700 [thread overview]
Message-ID: <49df8306-ecc7-b979-d887-b023275e4842@fb.com> (raw)
In-Reply-To: <20200630184922.455439-1-haoluo@google.com>
On 6/30/20 11:49 AM, Hao Luo wrote:
> The test_vmlinux test uses hrtimer_nanosleep as hook to test tracing
> programs. But it seems Clang may have done an aggressive optimization,
> causing fentry and kprobe to not hook on this function properly on a
> Clang build kernel.
Could you explain why it does not on clang built kernel? How did you
build the kernel? Did you use [thin]lto?
hrtimer_nanosleep is a global function who is called in several
different files. I am curious how clang optimization can make
function disappear, or make its function signature change, or
rename the function?
>
> A possible fix is switching to use a more reliable function, e.g. the
> ones exported to kernel modules such as hrtimer_range_start_ns. After
> we switch to using hrtimer_range_start_ns, the test passes again even
> on a clang build kernel.
>
> Tested:
> In a clang build kernel, the test fail even when the flags
> {fentry, kprobe}_called are set unconditionally in handle__kprobe()
> and handle__fentry(), which implies the programs do not hook on
> hrtimer_nanosleep() properly. This could be because clang's code
> transformation is too aggressive.
>
> test_vmlinux:PASS:skel_open 0 nsec
> test_vmlinux:PASS:skel_attach 0 nsec
> test_vmlinux:PASS:tp 0 nsec
> test_vmlinux:PASS:raw_tp 0 nsec
> test_vmlinux:PASS:tp_btf 0 nsec
> test_vmlinux:FAIL:kprobe not called
> test_vmlinux:FAIL:fentry not called
>
> After we switch to hrtimer_range_start_ns, the test passes.
>
> test_vmlinux:PASS:skel_open 0 nsec
> test_vmlinux:PASS:skel_attach 0 nsec
> test_vmlinux:PASS:tp 0 nsec
> test_vmlinux:PASS:raw_tp 0 nsec
> test_vmlinux:PASS:tp_btf 0 nsec
> test_vmlinux:PASS:kprobe 0 nsec
> test_vmlinux:PASS:fentry 0 nsec
>
> Signed-off-by: Hao Luo <haoluo@google.com>
> ---
> tools/testing/selftests/bpf/progs/test_vmlinux.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/test_vmlinux.c b/tools/testing/selftests/bpf/progs/test_vmlinux.c
> index 5611b564d3b1..29fa09d6a6c6 100644
> --- a/tools/testing/selftests/bpf/progs/test_vmlinux.c
> +++ b/tools/testing/selftests/bpf/progs/test_vmlinux.c
> @@ -63,20 +63,20 @@ int BPF_PROG(handle__tp_btf, struct pt_regs *regs, long id)
> return 0;
> }
>
> -SEC("kprobe/hrtimer_nanosleep")
> -int BPF_KPROBE(handle__kprobe,
> - ktime_t rqtp, enum hrtimer_mode mode, clockid_t clockid)
> +SEC("kprobe/hrtimer_start_range_ns")
> +int BPF_KPROBE(handle__kprobe, struct hrtimer *timer, ktime_t tim, u64 delta_ns,
> + const enum hrtimer_mode mode)
> {
> - if (rqtp == MY_TV_NSEC)
> + if (tim == MY_TV_NSEC)
> kprobe_called = true;
> return 0;
> }
>
> -SEC("fentry/hrtimer_nanosleep")
> -int BPF_PROG(handle__fentry,
> - ktime_t rqtp, enum hrtimer_mode mode, clockid_t clockid)
> +SEC("fentry/hrtimer_start_range_ns")
> +int BPF_PROG(handle__fentry, struct hrtimer *timer, ktime_t tim, u64 delta_ns,
> + const enum hrtimer_mode mode)
> {
> - if (rqtp == MY_TV_NSEC)
> + if (tim == MY_TV_NSEC)
> fentry_called = true;
> return 0;
> }
>
next prev parent reply other threads:[~2020-06-30 20:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 18:49 [PATCH bpf-next] selftests/bpf: Switch test_vmlinux to use hrtimer_range_start_ns Hao Luo
2020-06-30 20:36 ` Yonghong Song [this message]
2020-06-30 22:48 ` Hao Luo
2020-07-01 0:06 ` Bill Wendling
2020-07-01 0:10 ` Hao Luo
2020-07-01 2:26 ` Yonghong Song
2020-07-01 17:02 ` Hao Luo
2020-06-30 21:26 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49df8306-ecc7-b979-d887-b023275e4842@fb.com \
--to=yhs@fb.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).