linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
To: Duncan Roe <duncan_roe@optusnet.com.au>
Cc: Julian Anastasov <ja@ssi.bg>, Shuah Khan <shuah@kernel.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	"David S. Miller" <davem@davemloft.net>,
	Simon Horman <horms@verge.net.au>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] selftests: netfilter: introduce test cases for ipvs
Date: Sat, 5 Oct 2019 09:05:37 +0800	[thread overview]
Message-ID: <4C9C0C54-4CC6-49A4-A868-6F7604B1AB2B@cmss.chinamobile.com> (raw)
In-Reply-To: <20191004114745.GB6803@dimstar.local.net>


> On 2019年10月4日, at 下午7:47, Duncan Roe <duncan_roe@optusnet.com.au> wrote:
> 
> On Thu, Oct 03, 2019 at 10:41:06PM +0800, Haishuang Yan wrote:
>> 
>> 
>>> On 2019??10??2??, at ????9:27, Duncan Roe <duncan_roe@optusnet.com.au> wrote:
>>> 
>>> On Tue, Oct 01, 2019 at 09:34:13PM +0300, Julian Anastasov wrote:
>>>> 
>>>> 	Hello,
>>>> 
>>>> On Tue, 1 Oct 2019, Haishuang Yan wrote:
>>>> 
>>>>> This series patch include test cases for ipvs.
>>>>> 
>>>>> The test topology is who as below:
>>>>> +--------------------------------------------------------------+
>>>>> |                      |                                       |
>>>>> |         ns0          |         ns1                           |
>>>>> |      -----------     |     -----------    -----------        |
>>>>> |      | veth01  | --------- | veth10  |    | veth12  |        |
>>>>> |      -----------    peer   -----------    -----------        |
>>>>> |           |          |                        |              |
>>>>> |      -----------     |                        |              |
>>>>> |      |  br0    |     |-----------------  peer |--------------|
>>>>> |      -----------     |                        |              |
>>>>> |           |          |                        |              |
>>>>> |      ----------     peer   ----------      -----------       |
>>>>> |      |  veth02 | --------- |  veth20 |     | veth12  |       |
>>>>> |      ----------      |     ----------      -----------       |
>>>>> |                      |         ns2                           |
>>>>> |                      |                                       |
>>>>> +--------------------------------------------------------------+
>>>>> 
>>>>> Test results:
>>>>> # selftests: netfilter: ipvs.sh
>>>>> # Testing DR mode...
>>>>> # Testing NAT mode...
>>>>> # Testing Tunnel mode...
>>>>> # ipvs.sh: PASS
>>>>> ok 6 selftests: netfilter: ipvs.sh
>>>>> 
>>>>> Haishuang Yan (3):
>>>>> selftests: netfilter: add ipvs test script
>>>>> selftests: netfilter: add ipvs nat test case
>>>>> selftests: netfilter: add ipvs tunnel test case
>>>> 
>>>> Acked-by: Julian Anastasov <ja@ssi.bg>
>>>> 
>>>>> tools/testing/selftests/netfilter/Makefile |   2 +-
>>>>> tools/testing/selftests/netfilter/ipvs.sh  | 234 +++++++++++++++++++++++++++++
>>>>> 2 files changed, 235 insertions(+), 1 deletion(-)
>>>>> create mode 100755 tools/testing/selftests/netfilter/ipvs.sh
>>>> 
>>>> Regards
>>>> 
>>>> --
>>>> Julian Anastasov <ja@ssi.bg>
>>> 
>>> I still prefer #!/bin/sh in 1/3. You never know what's in someone's environment
>>> 
>>> Cheers ... Duncan.
>>> 
>> 
>> It??s also my preference too. "_"	
>> 
>> I have tested both #!/bin/bash and #!/bin/sh script, they all works properly.
> 
> Enter these 2 lines:
>> ip(){ return 0; }
>> export -f ip
> 
> Now try the #!/bin/bash script. If that now fails, try again with #!/bin/bash
> changed to #!/bin/bash -p
> 
> Any better now?
> 
> Cheers ... Duncan.
> 
It’s better now, thanks for your explanation.
In v3 commit I will use #!/bin/bash -p to prevent exporting function from environment variables.


      reply	other threads:[~2019-10-05  1:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 14:19 Haishuang Yan
2019-10-01 14:19 ` [PATCH v3 1/3] selftests: netfilter: add ipvs test script Haishuang Yan
2019-10-01 14:19 ` [PATCH v3 2/3] selftests: netfilter: add ipvs nat test case Haishuang Yan
2019-10-01 14:19 ` [PATCH v3 3/3] selftests: netfilter: add ipvs tunnel " Haishuang Yan
2019-10-01 18:34 ` [PATCH v3 0/3] selftests: netfilter: introduce test cases for ipvs Julian Anastasov
2019-10-02  1:27   ` Duncan Roe
2019-10-02  7:29     ` Simon Horman
     [not found]     ` <8E2E81F3-8385-4397-9A22-F513E507507D@cmss.chinamobile.com>
2019-10-04 11:47       ` Duncan Roe
2019-10-05  1:05         ` Haishuang Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9C0C54-4CC6-49A4-A868-6F7604B1AB2B@cmss.chinamobile.com \
    --to=yanhaishuang@cmss.chinamobile.com \
    --cc=davem@davemloft.net \
    --cc=duncan_roe@optusnet.com.au \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=shuah@kernel.org \
    --subject='Re: [PATCH v3 0/3] selftests: netfilter: introduce test cases for ipvs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).