linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] selftests: kvm: Fix libkvm build error
@ 2019-10-02 23:14 Shuah Khan
  2019-10-03 10:00 ` Paolo Bonzini
  0 siblings, 1 reply; 2+ messages in thread
From: Shuah Khan @ 2019-10-02 23:14 UTC (permalink / raw)
  To: pbonzini, rkrcmar, shuah; +Cc: Shuah Khan, kvm, linux-kselftest, linux-kernel

Fix the following build error from "make TARGETS=kvm kselftest":

libkvm.a(assert.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a PIE object; recompile with -fPIC

This error is seen when build is done from the main Makefile using
kselftest target. In this case KBUILD_CPPFLAGS and CC_OPTION_CFLAGS
are defined.

When build is invoked using:

"make -C tools/testing/selftests/kvm" KBUILD_CPPFLAGS and CC_OPTION_CFLAGS
aren't defined.

There is no need to pass in KBUILD_CPPFLAGS and CC_OPTION_CFLAGS for the
check to determine if --no-pie is necessary, which is the case when these
two aren't defined when "make -C tools/testing/selftests/kvm" runs.

Fix it by simplifying the no-pie-option logic. With this change, both
build variations work.

"make TARGETS=kvm kselftest"
"make -C tools/testing/selftests/kvm"

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
Changes since v2:
-- Removed extra blank line added by accident.
-- Fixed commit log.

 tools/testing/selftests/kvm/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
index 62c591f87dab..7ee097658ef0 100644
--- a/tools/testing/selftests/kvm/Makefile
+++ b/tools/testing/selftests/kvm/Makefile
@@ -48,7 +48,7 @@ CFLAGS += -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99 \
 	-I$(LINUX_HDR_PATH) -Iinclude -I$(<D) -Iinclude/$(UNAME_M) -I..
 
 no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \
-        $(CC) -Werror $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) -no-pie -x c - -o "$$TMP", -no-pie)
+        $(CC) -Werror -no-pie -x c - -o "$$TMP", -no-pie)
 
 # On s390, build the testcases KVM-enabled
 pgste-option = $(call try-run, echo 'int main() { return 0; }' | \
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] selftests: kvm: Fix libkvm build error
  2019-10-02 23:14 [PATCH v3] selftests: kvm: Fix libkvm build error Shuah Khan
@ 2019-10-03 10:00 ` Paolo Bonzini
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2019-10-03 10:00 UTC (permalink / raw)
  To: Shuah Khan, rkrcmar, shuah; +Cc: kvm, linux-kselftest, linux-kernel

On 03/10/19 01:14, Shuah Khan wrote:
> Fix the following build error from "make TARGETS=kvm kselftest":
> 
> libkvm.a(assert.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a PIE object; recompile with -fPIC
> 
> This error is seen when build is done from the main Makefile using
> kselftest target. In this case KBUILD_CPPFLAGS and CC_OPTION_CFLAGS
> are defined.
> 
> When build is invoked using:
> 
> "make -C tools/testing/selftests/kvm" KBUILD_CPPFLAGS and CC_OPTION_CFLAGS
> aren't defined.
> 
> There is no need to pass in KBUILD_CPPFLAGS and CC_OPTION_CFLAGS for the
> check to determine if --no-pie is necessary, which is the case when these
> two aren't defined when "make -C tools/testing/selftests/kvm" runs.
> 
> Fix it by simplifying the no-pie-option logic. With this change, both
> build variations work.
> 
> "make TARGETS=kvm kselftest"
> "make -C tools/testing/selftests/kvm"
> 
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
> Changes since v2:
> -- Removed extra blank line added by accident.
> -- Fixed commit log.
> 
>  tools/testing/selftests/kvm/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
> index 62c591f87dab..7ee097658ef0 100644
> --- a/tools/testing/selftests/kvm/Makefile
> +++ b/tools/testing/selftests/kvm/Makefile
> @@ -48,7 +48,7 @@ CFLAGS += -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99 \
>  	-I$(LINUX_HDR_PATH) -Iinclude -I$(<D) -Iinclude/$(UNAME_M) -I..
>  
>  no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \
> -        $(CC) -Werror $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) -no-pie -x c - -o "$$TMP", -no-pie)
> +        $(CC) -Werror -no-pie -x c - -o "$$TMP", -no-pie)
>  
>  # On s390, build the testcases KVM-enabled
>  pgste-option = $(call try-run, echo 'int main() { return 0; }' | \
> 

Queued, thanks.

Paolo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-03 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 23:14 [PATCH v3] selftests: kvm: Fix libkvm build error Shuah Khan
2019-10-03 10:00 ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).