From: shuah <shuah@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: linux-kselftest@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dmitry Safonov <dima@arista.com>, shuah <shuah@kernel.org>
Subject: Re: Linux 5.6-rc1 kselftest build failures
Date: Wed, 12 Feb 2020 10:38:05 -0700 [thread overview]
Message-ID: <5311f218-9bb0-4792-c469-019c7c2db7ee@kernel.org> (raw)
In-Reply-To: <20200212081414.7bwkndf6qxg2p35a@yavin>
On 2/12/20 1:14 AM, Aleksa Sarai wrote:
> On 2020-02-11, shuah <shuah@kernel.org> wrote:
>> openat2:
>>
>> tools/testing/selftests/openat2'
>> gcc -Wall -O2 -g -fsanitize=address -fsanitize=undefined openat2_test.c
>> helpers.c -o tools/testing/selftests/openat2/openat2_test
>> In file included from /usr/include/fcntl.h:301,
>> from helpers.c:9:
>> In function ‘openat’,
>> inlined from ‘touchat’ at helpers.c:49:11:
>> /usr/include/x86_64-linux-gnu/bits/fcntl2.h:126:4: error: call to
>> ‘__openat_missing_mode’ declared with attribute error: openat with O_CREAT
>> or O_TMPFILE in third argument needs 4 arguments
>> 126 | __openat_missing_mode ();
>> | ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Yeah, that's a brain-o -- it looks like you have a newer glibc than
> me which gives you a warning when you don't set the mode. The fix should
> be just the following:
>
Nice. Do you mind sending a proper patch, I can pull in.
thanks,
-- Shuah
next prev parent reply other threads:[~2020-02-12 17:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 0:35 Linux 5.6-rc1 kselftest build failures shuah
2020-02-12 8:14 ` Aleksa Sarai
2020-02-12 17:38 ` shuah [this message]
2020-02-13 7:27 ` Aleksa Sarai
2020-02-12 14:09 ` Dmitry Safonov
2020-02-12 18:16 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5311f218-9bb0-4792-c469-019c7c2db7ee@kernel.org \
--to=shuah@kernel.org \
--cc=cyphar@cyphar.com \
--cc=dima@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).