From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D99BCA9EC8 for ; Thu, 17 Oct 2019 23:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E32DC21D7A for ; Thu, 17 Oct 2019 23:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571355779; bh=8WlFJ81tyMyOS7mV7Y2mfwWAvtU+WMdpwxohESRAC9Q=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=2rr1Gtk6gV8Ek+zz1FRnSqvygvmqHjUjo27YRWqaIKxfLkdDsLr7dq4okxoNyF5EK +CsTOqwVLu0Owv6V71U14VdvqpZQ9G8YYagPwwpTUHio5E4hN9Fm1BTyR2RoxmpVPU E3/a6c+rOiY1GPFXDaGjdRaPDaMViDTbWZh/1I8I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438671AbfJQXm6 (ORCPT ); Thu, 17 Oct 2019 19:42:58 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:46682 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438582AbfJQXm6 (ORCPT ); Thu, 17 Oct 2019 19:42:58 -0400 Received: by mail-il1-f196.google.com with SMTP id c4so3794591ilq.13 for ; Thu, 17 Oct 2019 16:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Vw4ldBye3TR94WtUSfGYR0rQPaoBVOS5utrqGwpOO0A=; b=Na0+GRKMnASQ+fxY5uh4yM7YZn8rKC+8PSHM8MqwP5mrtYoa3dOn12Jl1Tjf0qnGvE sAIbMX4gwrnggmxqUbnQ0efeRW/+j5tpC6o47KB5GkrUcGKSGLYGEE3ompQnEKMzr2Be g8r2/Lo6ncZNYolD4Q9dpiZc4ZOeL3d4S3+U8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Vw4ldBye3TR94WtUSfGYR0rQPaoBVOS5utrqGwpOO0A=; b=blnMx2oDITBAnFCY5zj284Aj+/o0y+HqbEjE7h3czqwIUCRHOcSXnMtBKRQsg55I2x dVbaUgo8xT3kFx9EbZsMH3ucnyu0pjDECkPAdW0YM3c6o6oP+qBHNxs2kSb9STPs5qaJ zVd2+Y8qdzK2n04x+LD64IcuQXjZjH3F+Hb/Wd9aAHv+cxrokfh6pJM+JCBR9TlAcFsM Vh6/VfV//z65reZd5787Hxue3feTzRi9pDIk5EpdsJvt8qb0XlHCP73Q7r4EDwNXtr77 3cyRzl9fXwGcGCIjCcV6iQ1ZaOdykyQHbs8mYeYCkOLe0L+sr2X+59S/gu5MkICvOaXW wCbQ== X-Gm-Message-State: APjAAAXk6tUMiM+f6Mb+9bt12YT+blWfVswYhoX/0sbI37QWMgylnXhc dyCSMvqJ6vLm4IMDWcNTEimv6w== X-Google-Smtp-Source: APXvYqx1xB7DQxPw+YObD9tYUUmTob1HabrBcMc5TkE8UNGX5zqbAV6hW7f7YAt7gNi1LvnHi8jU8g== X-Received: by 2002:a92:bb81:: with SMTP id x1mr7038124ilk.299.1571355777298; Thu, 17 Oct 2019 16:42:57 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 6sm1261929ion.66.2019.10.17.16.42.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Oct 2019 16:42:56 -0700 (PDT) Subject: Re: [PATCH linux-kselftest/test v2] ext4: add kunit test for decoding extended timestamps To: Iurii Zaikin Cc: "Theodore Y. Ts'o" , Brendan Higgins , "open list:KERNEL SELFTEST FRAMEWORK" , linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, KUnit Development , Shuah Khan References: <20191010023931.230475-1-yzaikin@google.com> <2f2ea7b0-f683-1cdd-f3f2-ecdf44cb4a97@linuxfoundation.org> <20191011131902.GC16225@mit.edu> <1e6611e6-2fa6-6f7d-bc7f-0bc2243d9342@linuxfoundation.org> <20191017120833.GA25548@mit.edu> <957434b6-32cc-487f-f48e-f9c4416b3f60@linuxfoundation.org> <40073fc9-1de1-9253-e2f9-9cf9ee4308d4@linuxfoundation.org> From: Shuah Khan Message-ID: <56189643-af2b-f754-bc95-60ab4f126c32@linuxfoundation.org> Date: Thu, 17 Oct 2019 17:42:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/17/19 5:27 PM, Iurii Zaikin wrote: >> You can do all of this and allow users to supply another set of data. >> It doesn't gave to be one or the other. >> > What is the use case for running a unit test on a different data set than > what it comes with? > Let me ask the question in a different way. I would like to see the ability supply test data at run-time. It can be the same data every single time the test runs. I am not seeing the reasons to embed the test data in the test itself. thanks, -- Shuah