From: Zi Yan <ziy@nvidia.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Yang Shi <shy828301@gmail.com>, Yu Zhao <yuzhao@google.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/5] mm: page_owner: add support for splitting to any order in split page_owner.
Date: Fri, 24 Mar 2023 11:22:52 -0400 [thread overview]
Message-ID: <59100CE6-1A77-4620-81AC-535A6A68A98F@nvidia.com> (raw)
In-Reply-To: <20230324151717.hawuy5gs6cnxql55@blackpad>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On 24 Mar 2023, at 11:17, Michal Koutný wrote:
> Hello.
>
> On Mon, Mar 20, 2023 at 08:48:26PM -0400, Zi Yan <zi.yan@sent.com> wrote:
>> @@ -5746,8 +5746,8 @@ static void *make_alloc_exact(unsigned long addr, unsigned int order,
>> struct page *page = virt_to_page((void *)addr);
>> struct page *last = page + nr;
>>
>> - split_page_owner(page, 1 << order);
>> - split_page_memcg(page, 1 << order);
>> + split_page_owner(page, 1 << order, 1);
>> + split_page_memcg(page, 1 << order, 1);
>
> I think here should be
>
>> + split_page_owner(page, order, 0);
>> + split_page_memcg(page, 1 << order, 1);
>
> because I was wondering why split_page_memcg() doesn't use orders too?
> (E.g. it wouldn't work well if nr % new_new != 0).
Thanks. Good point. I will make both use orders instead in next version.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2023-03-24 15:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 0:48 [PATCH 0/5] Split a folio to any lower order folios Zi Yan
2023-03-21 0:48 ` [PATCH 1/5] mm: memcg: make memcg huge page split support any order split Zi Yan
2023-03-21 0:48 ` [PATCH 2/5] mm: page_owner: add support for splitting to any order in split page_owner Zi Yan
2023-03-24 15:17 ` Michal Koutný
2023-03-24 15:22 ` Zi Yan [this message]
2023-03-21 0:48 ` [PATCH 3/5] mm: thp: split huge page to any lower order pages Zi Yan
2023-03-22 7:55 ` Ryan Roberts
2023-03-22 14:27 ` Zi Yan
2023-03-22 14:48 ` Ryan Roberts
2023-03-21 0:48 ` [PATCH 4/5] mm: truncate: split huge page cache page to a non-zero order if possible Zi Yan
2023-03-21 0:48 ` [PATCH 5/5] mm: huge_memory: enable debugfs to split huge pages to any order Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59100CE6-1A77-4620-81AC-535A6A68A98F@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).