linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: shuah <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH v2] selftests: fix prepending $(OUTPUT) to $(TEST_PROGS)
Date: Mon, 30 Sep 2019 19:50:21 +0200	[thread overview]
Message-ID: <5CE66619-878B-4CC7-8477-32050A131FB4@linux.ibm.com> (raw)
In-Reply-To: <cb4e3c3c-3ab8-5d21-495f-5f751c79dde6@kernel.org>

> Am 16.09.2019 um 18:18 schrieb shuah <shuah@kernel.org>:
> 
> On 9/10/19 6:18 AM, Ilya Leoshkevich wrote:
>> The current logic prepends $(OUTPUT) only to the first member of
>> $(TEST_PROGS). Use $(addprefix) to prepend it to each member.
> 
> Can you please send me the error messages you are seeing so I can see
> what is being fixed.

linux# make kselftest TARGETS=bpf O=/mnt/linux-build

Without the patch:
# selftests: bpf: test_libbpf.sh
# ./test_libbpf.sh: line 23: ./test_libbpf_open: No such file or directory
# test_libbpf: failed at file test_l4lb.o
# selftests: test_libbpf [FAILED]

With the patch:
# selftests: bpf: test_libbpf.sh
# selftests: test_libbpf [PASS]

What happens is that run_one() does

    cd `dirname $TEST`

dirname is . without the patch, so the test cannot access the files
generated in $(OUTPUT).

> 
>> Also, $(OUTPUT) is assumed to end with a / almost everywhere else in
>> the kernel, make this the case for kselftest as well.
> 
> Why are these two changes in one patch? Does this fix 1a940687e424?
> If so how?

I will split the patch in two and resend. Adding / does not fix
anything, it just makes the code more uniform w.r.t. the rest of the
tree.


      reply	other threads:[~2019-09-30 20:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 12:18 Ilya Leoshkevich
2019-09-16 16:18 ` shuah
2019-09-30 17:50   ` Ilya Leoshkevich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CE66619-878B-4CC7-8477-32050A131FB4@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --subject='Re: [PATCH v2] selftests: fix prepending $(OUTPUT) to $(TEST_PROGS)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).