linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [Bug report] "make run_tests -C bpf" hanging forever
@ 2019-10-18  6:32 Liu Yiding
  2019-10-18  6:41 ` Liu Yiding
  2019-10-18 16:21 ` Kees Cook
  0 siblings, 2 replies; 6+ messages in thread
From: Liu Yiding @ 2019-10-18  6:32 UTC (permalink / raw)
  To: Kees Cook; +Cc: linux-kselftest, Prabhakar Kushwaha, Shuah Khan

Hi All.

The patch 5c069b6dedef "selftests: Move test output to diagnostic lines" 
from Apr 24, 2019,

leads to `make run_tests -C bpf` hanging forever.


Bpf includes many subtest, when cmd `make run_tests -C bpf` runs to 
test_lwt_seg6local.sh, task will hang and runner.sh never run next task. 
I checked ps aux, prefix.pl will never exit.

```

91058 [  811.451584] # [25] VAR __license type_id=24 linkage=1
91059 [  811.451586]-
91060 [  811.455365] # [26] DATASEC license size=0 vlen=1 size == 0
91061 [  811.455367]-
91062 [  811.457424] #-
91063 [  811.457425]-
91064 [  811.460912] # selftests: test_lwt_seg6local [PASS]
91065 [  811.460914]-
91066 [ 3620.461986] Thu Oct 17 14:54:05 CST 2019 detected soft_timeout

```

Ignore test_lwt_seg6local and run `make run_tests -C bpf` again, task 
will hang on test_tc_tunnel.sh.


Kushwaha also meet this issue, `make run_tests -C bpf` hang on 
test_lwt_ip_encap.sh (This test failed on my localhost).

-- 
Best regards.
Liu Yiding




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug report] "make run_tests -C bpf" hanging forever
  2019-10-18  6:32 [Bug report] "make run_tests -C bpf" hanging forever Liu Yiding
@ 2019-10-18  6:41 ` Liu Yiding
  2019-10-18  6:56   ` Prabhakar Kushwaha
  2019-10-18 16:21 ` Kees Cook
  1 sibling, 1 reply; 6+ messages in thread
From: Liu Yiding @ 2019-10-18  6:41 UTC (permalink / raw)
  To: Kees Cook; +Cc: linux-kselftest, Prabhakar Kushwaha, Shuah Khan, Philip Li

CC LKP mainter


On 10/18/19 2:32 PM, Liu Yiding wrote:
> Hi All.
>
> The patch 5c069b6dedef "selftests: Move test output to diagnostic 
> lines" from Apr 24, 2019,
>
> leads to `make run_tests -C bpf` hanging forever.
>
>
> Bpf includes many subtest, when cmd `make run_tests -C bpf` runs to 
> test_lwt_seg6local.sh, task will hang and runner.sh never run next 
> task. I checked ps aux, prefix.pl will never exit.
>
> ```
>
> 91058 [  811.451584] # [25] VAR __license type_id=24 linkage=1
> 91059 [  811.451586]-
> 91060 [  811.455365] # [26] DATASEC license size=0 vlen=1 size == 0
> 91061 [  811.455367]-
> 91062 [  811.457424] #-
> 91063 [  811.457425]-
> 91064 [  811.460912] # selftests: test_lwt_seg6local [PASS]
> 91065 [  811.460914]-
> 91066 [ 3620.461986] Thu Oct 17 14:54:05 CST 2019 detected soft_timeout
>
> ```
>
> Ignore test_lwt_seg6local and run `make run_tests -C bpf` again, task 
> will hang on test_tc_tunnel.sh.
>
>
> Kushwaha also meet this issue, `make run_tests -C bpf` hang on 
> test_lwt_ip_encap.sh (This test failed on my localhost).
>
-- 
Best regards.
Liu Yiding




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug report] "make run_tests -C bpf" hanging forever
  2019-10-18  6:41 ` Liu Yiding
@ 2019-10-18  6:56   ` Prabhakar Kushwaha
  2019-10-18 15:01     ` Shuah Khan
  0 siblings, 1 reply; 6+ messages in thread
From: Prabhakar Kushwaha @ 2019-10-18  6:56 UTC (permalink / raw)
  To: Liu Yiding; +Cc: Kees Cook, linux-kselftest, Shuah Khan, Philip Li

On Fri, Oct 18, 2019 at 12:12 PM Liu Yiding <liuyd.fnst@cn.fujitsu.com> wrote:
>
> CC LKP mainter
>
>
> On 10/18/19 2:32 PM, Liu Yiding wrote:
> > Hi All.
> >
> > The patch 5c069b6dedef "selftests: Move test output to diagnostic
> > lines" from Apr 24, 2019,
> >
> > leads to `make run_tests -C bpf` hanging forever.
> >
> >
> > Bpf includes many subtest, when cmd `make run_tests -C bpf` runs to
> > test_lwt_seg6local.sh, task will hang and runner.sh never run next
> > task. I checked ps aux, prefix.pl will never exit.
> >
> > ```
> >
> > 91058 [  811.451584] # [25] VAR __license type_id=24 linkage=1
> > 91059 [  811.451586]-
> > 91060 [  811.455365] # [26] DATASEC license size=0 vlen=1 size == 0
> > 91061 [  811.455367]-
> > 91062 [  811.457424] #-
> > 91063 [  811.457425]-
> > 91064 [  811.460912] # selftests: test_lwt_seg6local [PASS]
> > 91065 [  811.460914]-
> > 91066 [ 3620.461986] Thu Oct 17 14:54:05 CST 2019 detected soft_timeout
> >
> > ```
> >
> > Ignore test_lwt_seg6local and run `make run_tests -C bpf` again, task
> > will hang on test_tc_tunnel.sh.
> >
> >
> > Kushwaha also meet this issue, `make run_tests -C bpf` hang on
> > test_lwt_ip_encap.sh (This test failed on my localhost).
> >

Yes, i also faced this issue on Linux-5.3. if i kill prefix.pl or add
timeout in prefix.pl, test move ahead.

somehow this issue is not present on Linux 5.4-rc3+. It could be by
chance and may show on any other version.

--prabhakar (pk)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug report] "make run_tests -C bpf" hanging forever
  2019-10-18  6:56   ` Prabhakar Kushwaha
@ 2019-10-18 15:01     ` Shuah Khan
  2019-10-21  1:42       ` Liu Yiding
  0 siblings, 1 reply; 6+ messages in thread
From: Shuah Khan @ 2019-10-18 15:01 UTC (permalink / raw)
  To: Prabhakar Kushwaha, Liu Yiding, Kees Cook
  Cc: linux-kselftest, Philip Li, Shuah Khan

On 10/18/19 12:56 AM, Prabhakar Kushwaha wrote:
> On Fri, Oct 18, 2019 at 12:12 PM Liu Yiding <liuyd.fnst@cn.fujitsu.com> wrote:
>>
>> CC LKP mainter
>>
>>
>> On 10/18/19 2:32 PM, Liu Yiding wrote:
>>> Hi All.
>>>
>>> The patch 5c069b6dedef "selftests: Move test output to diagnostic
>>> lines" from Apr 24, 2019,
>>>
>>> leads to `make run_tests -C bpf` hanging forever.
>>>
>>>
>>> Bpf includes many subtest, when cmd `make run_tests -C bpf` runs to
>>> test_lwt_seg6local.sh, task will hang and runner.sh never run next
>>> task. I checked ps aux, prefix.pl will never exit.
>>>
>>> ```
>>>
>>> 91058 [  811.451584] # [25] VAR __license type_id=24 linkage=1
>>> 91059 [  811.451586]-
>>> 91060 [  811.455365] # [26] DATASEC license size=0 vlen=1 size == 0
>>> 91061 [  811.455367]-
>>> 91062 [  811.457424] #-
>>> 91063 [  811.457425]-
>>> 91064 [  811.460912] # selftests: test_lwt_seg6local [PASS]
>>> 91065 [  811.460914]-
>>> 91066 [ 3620.461986] Thu Oct 17 14:54:05 CST 2019 detected soft_timeout
>>>
>>> ```
>>>
>>> Ignore test_lwt_seg6local and run `make run_tests -C bpf` again, task
>>> will hang on test_tc_tunnel.sh.
>>>
>>>
>>> Kushwaha also meet this issue, `make run_tests -C bpf` hang on
>>> test_lwt_ip_encap.sh (This test failed on my localhost).
>>>
> 
> Yes, i also faced this issue on Linux-5.3. if i kill prefix.pl or add
> timeout in prefix.pl, test move ahead.
> 
> somehow this issue is not present on Linux 5.4-rc3+. It could be by
> chance and may show on any other version.
> 

Kees added timeout in this commit and this went into 5.4-rc3, if recall
correctly.

commit 852c8cbf34d3b3130a05c38064dd98614f97d3a8
Author: Kees Cook <keescook@chromium.org>

     selftests/kselftest/runner.sh: Add 45 second timeout per test

Do you see a timed out message from this test though. The test needs
to fixed probably, but this timeout helps bail out.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug report] "make run_tests -C bpf" hanging forever
  2019-10-18  6:32 [Bug report] "make run_tests -C bpf" hanging forever Liu Yiding
  2019-10-18  6:41 ` Liu Yiding
@ 2019-10-18 16:21 ` Kees Cook
  1 sibling, 0 replies; 6+ messages in thread
From: Kees Cook @ 2019-10-18 16:21 UTC (permalink / raw)
  To: Liu Yiding; +Cc: linux-kselftest, Prabhakar Kushwaha, Shuah Khan

On Fri, Oct 18, 2019 at 02:32:15PM +0800, Liu Yiding wrote:
> Hi All.
> 
> The patch 5c069b6dedef "selftests: Move test output to diagnostic lines"
> from Apr 24, 2019,
> 
> leads to `make run_tests -C bpf` hanging forever.

I can't even run this, the autodetection seems broken. I have BPF and
libelf installed....

$ make run_tests -C bpf
[...]

Auto-detecting system features:
...                        libelf: [ OFF ]
...                           bpf: [ OFF ]


Auto-detecting system features:
...                        libelf: [ OFF ]
...                           bpf: [ OFF ]

No libelf found
Makefile:269: recipe for target 'elfdep' failed
make[2]: *** [elfdep] Error 1
Makefile:154: recipe for target 'all' failed
make[1]: *** [all] Error 2


> Bpf includes many subtest, when cmd `make run_tests -C bpf` runs to
> test_lwt_seg6local.sh, task will hang and runner.sh never run next task. I
> checked ps aux, prefix.pl will never exit.
> 
> ```
> 
> 91058 [  811.451584] # [25] VAR __license type_id=24 linkage=1
> 91059 [  811.451586]-
> 91060 [  811.455365] # [26] DATASEC license size=0 vlen=1 size == 0
> 91061 [  811.455367]-
> 91062 [  811.457424] #-
> 91063 [  811.457425]-
> 91064 [  811.460912] # selftests: test_lwt_seg6local [PASS]
> 91065 [  811.460914]-
> 91066 [ 3620.461986] Thu Oct 17 14:54:05 CST 2019 detected soft_timeout
> 
> ```
> 
> Ignore test_lwt_seg6local and run `make run_tests -C bpf` again, task will
> hang on test_tc_tunnel.sh.
> 
> 
> Kushwaha also meet this issue, `make run_tests -C bpf` hang on
> test_lwt_ip_encap.sh (This test failed on my localhost).

If it keeps hanging on progressively later tests, it sounds like some
kind of stdout/stderr flushing (or reading) is missing. This is hard for
me to debug without understanding how to have the kernel tree notice my
installed libraries, though.

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug report] "make run_tests -C bpf" hanging forever
  2019-10-18 15:01     ` Shuah Khan
@ 2019-10-21  1:42       ` Liu Yiding
  0 siblings, 0 replies; 6+ messages in thread
From: Liu Yiding @ 2019-10-21  1:42 UTC (permalink / raw)
  To: Shuah Khan, Prabhakar Kushwaha, Kees Cook; +Cc: linux-kselftest, Philip Li

Hi, i test it on v5.3-rc4, also meet this issue.


On 10/18/19 11:01 PM, Shuah Khan wrote:
> On 10/18/19 12:56 AM, Prabhakar Kushwaha wrote:
>> On Fri, Oct 18, 2019 at 12:12 PM Liu Yiding 
>> <liuyd.fnst@cn.fujitsu.com> wrote:
>>>
>>> CC LKP mainter
>>>
>>>
>>> On 10/18/19 2:32 PM, Liu Yiding wrote:
>>>> Hi All.
>>>>
>>>> The patch 5c069b6dedef "selftests: Move test output to diagnostic
>>>> lines" from Apr 24, 2019,
>>>>
>>>> leads to `make run_tests -C bpf` hanging forever.
>>>>
>>>>
>>>> Bpf includes many subtest, when cmd `make run_tests -C bpf` runs to
>>>> test_lwt_seg6local.sh, task will hang and runner.sh never run next
>>>> task. I checked ps aux, prefix.pl will never exit.
>>>>
>>>> ```
>>>>
>>>> 91058 [  811.451584] # [25] VAR __license type_id=24 linkage=1
>>>> 91059 [  811.451586]-
>>>> 91060 [  811.455365] # [26] DATASEC license size=0 vlen=1 size == 0
>>>> 91061 [  811.455367]-
>>>> 91062 [  811.457424] #-
>>>> 91063 [  811.457425]-
>>>> 91064 [  811.460912] # selftests: test_lwt_seg6local [PASS]
>>>> 91065 [  811.460914]-
>>>> 91066 [ 3620.461986] Thu Oct 17 14:54:05 CST 2019 detected 
>>>> soft_timeout
>>>>
>>>> ```
>>>>
>>>> Ignore test_lwt_seg6local and run `make run_tests -C bpf` again, task
>>>> will hang on test_tc_tunnel.sh.
>>>>
>>>>
>>>> Kushwaha also meet this issue, `make run_tests -C bpf` hang on
>>>> test_lwt_ip_encap.sh (This test failed on my localhost).
>>>>
>>
>> Yes, i also faced this issue on Linux-5.3. if i kill prefix.pl or add
>> timeout in prefix.pl, test move ahead.
>>
>> somehow this issue is not present on Linux 5.4-rc3+. It could be by
>> chance and may show on any other version.
>>
>
> Kees added timeout in this commit and this went into 5.4-rc3, if recall
> correctly.
>
> commit 852c8cbf34d3b3130a05c38064dd98614f97d3a8
> Author: Kees Cook <keescook@chromium.org>
>
>     selftests/kselftest/runner.sh: Add 45 second timeout per test
>
> Do you see a timed out message from this test though. The test needs
> to fixed probably, but this timeout helps bail out.


I got TIMEOUT message for some tests, e.g. test_tunnel.sh, timeout works.

```

88418 user  :notice: [ 1258.787439] not ok 36 selftests: bpf: 
test_tunnel.sh # TIMEOUT

```


But test_lwt_seg6local still hang, it seems that this timeout is working 
for testscript and seg6local hang on tap_prefix (prefix.pl).

```

89008 user  :notice: [ 1259.886374] # [25] VAR __license type_id=24 
linkage=1
89009
89010 user  :notice: [ 1259.890166] # [26] DATASEC license size=0 vlen=1 
size == 0
89011
89012 user  :notice: [ 1259.893272] #-
89013
89014 user  :notice: [ 1259.897190] # selftests: test_lwt_seg6local [PASS]
89015
89016 user  :notice: [ 3623.763707] Fri Oct 18 16:12:56 CST 2019 
detected soft_timeout

```


>
>
> thanks,
> -- Shuah
>
>
-- 
Best regards.
Liu Yiding




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-10-21  1:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18  6:32 [Bug report] "make run_tests -C bpf" hanging forever Liu Yiding
2019-10-18  6:41 ` Liu Yiding
2019-10-18  6:56   ` Prabhakar Kushwaha
2019-10-18 15:01     ` Shuah Khan
2019-10-21  1:42       ` Liu Yiding
2019-10-18 16:21 ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).