From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F57C48BE5 for ; Thu, 17 Jun 2021 15:29:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B57061249 for ; Thu, 17 Jun 2021 15:29:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232454AbhFQPb3 (ORCPT ); Thu, 17 Jun 2021 11:31:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42851 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232288AbhFQPb2 (ORCPT ); Thu, 17 Jun 2021 11:31:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623943760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pJAYrboxNY4R4lDYsyxGAHwG1E3b8kp8BFkfADBjg3E=; b=D64Fv/b+luWfIGTjMAtzpsXERz8LnKDbLDnnyiWBAjL6sQc5VFtDkSqlZ4/XYxQ6PEb4LH 6WC0IDs/bxK0FDY2X6L+y0ixEX3QAxMjlPM9HFOKI2rNF3VPSZPpYCPP0R+tsG0xXyoEQ3 CtFRYfuZ1YO/E4rNewQYAWdaF11zj2I= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-sO9rhHoQNoeCWP2se71YGg-1; Thu, 17 Jun 2021 11:29:16 -0400 X-MC-Unique: sO9rhHoQNoeCWP2se71YGg-1 Received: by mail-ej1-f72.google.com with SMTP id jw19-20020a17090776b3b0290481592f1fc4so744988ejc.2 for ; Thu, 17 Jun 2021 08:29:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pJAYrboxNY4R4lDYsyxGAHwG1E3b8kp8BFkfADBjg3E=; b=P27Pg87zIpHyBClDYAkqikc9g8AAk7MlJNNcB2gcHCFgp6GQIQ1RThHQ+tuu3Kf97h UnNEd4mCOPQc20TsE7+6Sw/Gml1ayNAq1hvk+sfe5e+EiySoDTmNClj5IZ97tNFEACwu 49gq9Io17nxoHn3HT4xr3mg/HR7fD1AYQRemWYaHUVnqDiSTiBgQeEVBDLI+dVHyLRs3 g53Cd9zRuy1dk/7o9yEk8CnYhCz4xTQTJBW7nRHU2AZuf63ea8ILCE1N2OF0Dy2e99PH 7ECOtM553hLwbM+nugzg+1VBFHd1PMEsGvNLCK15jjk+HQoa2/vMHBk0KZCrVTGphawm 6xkQ== X-Gm-Message-State: AOAM533IcalAyFTP9YFd6zXNwmSJ+VKcHd164CmznohIZmvmfnCANiaT uY7oOsq5DNDXZPu1lY+mtT4k9PbHf5BJxM05ALZVVyZnu6jc0K/gLlmzGcXShS0BAKgwkei3swj bFR9YoxxEQCWMTZjQIstISzDJxWj0 X-Received: by 2002:a17:906:3c44:: with SMTP id i4mr5844964ejg.135.1623943755563; Thu, 17 Jun 2021 08:29:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwguprspLdKxfz1gQFsWZ9pANB4xL5Og2GYXcQQiXXJdl05NURoTWq9llwpGLS30bGiJxoGJQ== X-Received: by 2002:a17:906:3c44:: with SMTP id i4mr5844929ejg.135.1623943755347; Thu, 17 Jun 2021 08:29:15 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id z19sm4485528edc.90.2021.06.17.08.29.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 08:29:14 -0700 (PDT) Subject: Re: [PATCH v10 2/5] KVM: stats: Add fd-based API to read binary stats data To: Jing Zhang , Greg KH Cc: KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan , Fuad Tabba References: <20210617044146.2667540-1-jingzhangos@google.com> <20210617044146.2667540-3-jingzhangos@google.com> From: Paolo Bonzini Message-ID: <5ae75b1b-4cba-d06f-625b-35b42f11ac03@redhat.com> Date: Thu, 17 Jun 2021 17:29:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 17/06/21 16:56, Jing Zhang wrote: > Actually, it is really not easy to separate this change into two patches even by > following Paolo's suggestion. And it would be a surprise to userspace to see > only VM stats, no VCPU stats. That does not matter. Having two or three patches is useful because it makes review easier; they will never appear separately in a release. Paolo