From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5133C2D0DB for ; Fri, 24 Jan 2020 19:44:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE3BF20838 for ; Fri, 24 Jan 2020 19:44:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="otjafZ5/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391181AbgAXToG (ORCPT ); Fri, 24 Jan 2020 14:44:06 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:55507 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390664AbgAXToG (ORCPT ); Fri, 24 Jan 2020 14:44:06 -0500 Received: by mail-pj1-f65.google.com with SMTP id d5so257286pjz.5; Fri, 24 Jan 2020 11:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=raVWSvS9XFHbPPEUPPq10mdG0WqVl1OCni/0Sjj02+I=; b=otjafZ5/VEduhylPUceHLNPCA26p0zakAAG+Jm8wG22jex4RiPcjbb7HvguOiHw1PT nJ+GU4qSA11OQw7nOp5ldLkmpRskL0OgZV4WOWUQM/U106bqb2xhqzYbbbk/PJavauqD /Xm6jnE8H7TOE4UTns7QJJyKwi58MjzWpJUWqjSr1/nptoGpGzABpRdgqWiSwh1EgoIq A1Ng/zKlgYPxhd2UZ7WtfFJv/+hYVpzJph1XpArtNFkDTVySdioMxA2rZMv9/kMuaGQy 0h75uGvX2F3qhDjfgSAMx2R1RBhqG7W717ZhUJ9Q3mBtmlc9OH1UMd3p4op9wkq7T21p itiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=raVWSvS9XFHbPPEUPPq10mdG0WqVl1OCni/0Sjj02+I=; b=I4m7MA/sb5kwxrqyVPGUdsCbm0p1woc1cFEINHY+hgz4VcpcTM/RhuL2HZs6Cyf5Y4 JErLDfE/c9FTboo7SPKkG/B4HlUnau5zDn1vzIcJWslp4t0zmXDUZyXNv+qXrFtOcvrQ rQSlmQtwNyzJZhdaDmkuR362IticGKLJX/gOEGnWfbnzR9OhKSrwUCTRorZL7fuad0TJ GB8S6mC73jzI7Shpcs38O9x+sTmrivjHxL5/CUWqxG0CrPZ6rFF8nrLhfF0oMNe1exFb ktrXcjmLchq1W911ao4b2u1Q3ApAjrZ11WXwAObxc5n103X4RDuIxm9sc4DZhuG1p5Ar 4yQQ== X-Gm-Message-State: APjAAAXGEFs9kkQiyss/I3WKzUADm3Qu2zzPySTzpzc/A4V6PYr+Px6z 3VPE9WgxCHUSGzRXapdQLFg= X-Google-Smtp-Source: APXvYqwXFZrODteEJ/PTPSR4e4qIlOJx6rbQxDoYgmvjh/h89tdZD6pQ/yDsE8mIeQfb4qqiOMrCxg== X-Received: by 2002:a17:902:bc85:: with SMTP id bb5mr5119218plb.208.1579895046013; Fri, 24 Jan 2020 11:44:06 -0800 (PST) Received: from localhost ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id m3sm7091461pfh.116.2020.01.24.11.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2020 11:44:05 -0800 (PST) Date: Fri, 24 Jan 2020 11:43:57 -0800 From: John Fastabend To: Lorenz Bauer , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko Cc: Lorenz Bauer , linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <5e2b48fd34d98_551b2aaf5fbda5b834@john-XPS-13-9370.notmuch> In-Reply-To: <20200123165934.9584-2-lmb@cloudflare.com> References: <20200123165934.9584-1-lmb@cloudflare.com> <20200123165934.9584-2-lmb@cloudflare.com> Subject: RE: [PATCH bpf 1/4] selftests: bpf: use a temporary file in test_sockmap Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Lorenz Bauer wrote: > Use a proper temporary file for sendpage tests. This means that running > the tests doesn't clutter the working directory, and allows running the > test on read-only filesystems. > > Signed-off-by: Lorenz Bauer > --- > tools/testing/selftests/bpf/test_sockmap.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > Agree nice bit of cleanup. We should merge this in bpf-next though considering its late in the bpf tree. Acked-by: John Fastabend