From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A3AC32771 for ; Fri, 24 Jan 2020 19:45:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F1C2214AF for ; Fri, 24 Jan 2020 19:45:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U5MIHpAY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392286AbgAXTpe (ORCPT ); Fri, 24 Jan 2020 14:45:34 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:33349 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391381AbgAXTpc (ORCPT ); Fri, 24 Jan 2020 14:45:32 -0500 Received: by mail-pf1-f196.google.com with SMTP id n7so1582275pfn.0; Fri, 24 Jan 2020 11:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=uAtf8UFoE+PN3UiSFGJxqL2LItMWe3zK1JG/WM0xK54=; b=U5MIHpAYiYl1tN/v3wBtlCpWWQexc2PBHipYhnlZY01BU1nYEXQcem3ktSO8CCb+WL 3TyytFB9d6FN7CCayl/+jR9ywTrykenI1ObFjcmwvX2G8+5TiPFtBE5VqaWogzcezRG1 xd83kKQH/yoFyC5twgYIAozwljhO4ujvci1eDn/6P2Wzv4G8QyoOegB/ZOFmhQuh7NDj L9PEu6s6QeuVUrhPJhR1bNCsODFJWMX/5kTtkF6Yj//lvXHmSrHV4BZVM7Zmx5lIm2TL OkdhRFXMHkx3sZVPG1u2ekg1OXTwB5m47H/8fhGGuFZfSq7DL1T/5xlby2E3oMNcAsRv e8QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=uAtf8UFoE+PN3UiSFGJxqL2LItMWe3zK1JG/WM0xK54=; b=RcmoA+p36Ir2uLEy6UqRRvYX6pSqHrDsBBoujz2rtEiFHbfUp+Fv60sd3KA75IEe/r XsK4kJg0Bb0ZZVfjeBVZ+ThuDioj3lKd1wYsKuy7BaIx0+YAUCLuF16Nd25EygdED/3m QqWG2yst6cn9WUvwEmJGMlj7vQDgs91VzZXqLY6Hj8N1Cckuj/GeG/wxQhNrFaCjxqF/ SsH/C5hyENL6YyTcM2XlFYWC7ZUtsE3m5YLLi1IwxvOwSEJX/OxigxS8eDdPHAzy+di4 x0jBvKiEk8g8QuyG8SisjqN6VY8+edA3WfJ+sp7ZjLmxHc2q91pNfy66mNPwKADLZTlg rNVA== X-Gm-Message-State: APjAAAV/eqOeFjiP7BD4p6Gw3q0HakWC8SnQxaXipDz9xdFbrXMv2rO8 MfMhDmsJXKiITpnn/rDxbw49C11F X-Google-Smtp-Source: APXvYqx/gD/MSaVKp9vFpCooVWOq+vZEktSonTpjCqs1EQsClDOZoYp4KvvGpzmHryLBmoNbVaG/ow== X-Received: by 2002:a63:b50a:: with SMTP id y10mr5898440pge.104.1579895131757; Fri, 24 Jan 2020 11:45:31 -0800 (PST) Received: from localhost ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id u127sm7268053pfc.95.2020.01.24.11.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2020 11:45:31 -0800 (PST) Date: Fri, 24 Jan 2020 11:45:24 -0800 From: John Fastabend To: Lorenz Bauer , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko Cc: Lorenz Bauer , linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <5e2b495476333_551b2aaf5fbda5b85d@john-XPS-13-9370.notmuch> In-Reply-To: <20200123165934.9584-3-lmb@cloudflare.com> References: <20200123165934.9584-1-lmb@cloudflare.com> <20200123165934.9584-3-lmb@cloudflare.com> Subject: RE: [PATCH bpf 2/4] selftests: bpf: ignore RST packets for reuseport tests Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Lorenz Bauer wrote: > The reuseport tests currently suffer from a race condition: RST > packets count towards DROP_ERR_SKB_DATA, since they don't contain > a valid struct cmd. Tests will spuriously fail depending on whether > check_results is called before or after the RST is processed. > > Exit the BPF program early if FIN is set. > > Signed-off-by: Lorenz Bauer > --- > .../selftests/bpf/progs/test_select_reuseport_kern.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/testing/selftests/bpf/progs/test_select_reuseport_kern.c b/tools/testing/selftests/bpf/progs/test_select_reuseport_kern.c > index d69a1f2bbbfd..26e77dcc7e91 100644 > --- a/tools/testing/selftests/bpf/progs/test_select_reuseport_kern.c > +++ b/tools/testing/selftests/bpf/progs/test_select_reuseport_kern.c > @@ -113,6 +113,12 @@ int _select_by_skb_data(struct sk_reuseport_md *reuse_md) > data_check.skb_ports[0] = th->source; > data_check.skb_ports[1] = th->dest; > > + if (th->fin) > + /* The connection is being torn down at the end of a > + * test. It can't contain a cmd, so return early. > + */ > + return SK_PASS; > + > if ((th->doff << 2) + sizeof(*cmd) > data_check.len) > GOTO_DONE(DROP_ERR_SKB_DATA); > if (bpf_skb_load_bytes(reuse_md, th->doff << 2, &cmd_copy, > -- > 2.20.1 > Acked-by: John Fastabend