From: Shuah Khan <skhan@linuxfoundation.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
rkrcmar@redhat.com, shuah@kernel.org
Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: kvm: Fix libkvm build error
Date: Wed, 25 Sep 2019 10:47:42 -0600 [thread overview]
Message-ID: <5fecb8a8-8a6a-1e2b-78e3-5660597a02e4@linuxfoundation.org> (raw)
In-Reply-To: <dbfb9d46-488a-b940-c86f-79ad750a324a@redhat.com>
On 9/25/19 1:48 AM, Paolo Bonzini wrote:
> On 24/09/19 22:14, Shuah Khan wrote:
>> Fix the following build error:
>>
>> libkvm.a(assert.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a PIE object; recompile with -fPIC
>>
>> Add -fPIC to CFLAGS to fix it.
>
> This is wrong, these testcases cannot be position-independent
> executables. Can you include the failing command line from "V=1"
> output?
>
You are right. This isn't correct.
> The problem seems to be that these definitions are not working properly:
>
> no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \
> $(CC) -Werror $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) -no-pie -x c - -o "$$TMP", -no-pie)
>
> LDFLAGS += -pthread $(no-pie-option)
>
Yup. That is what is happening, when I build using
"make TARGETS=kvm kselftest"
You can see this below:
gcc -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99
-fno-stack-protector -fno-PIE -I../../../../tools/include
-I../../../../usr/include/ -Iinclude -Ix86_64 -Iinclude/x86_64 -I..
-pthread x86_64/cr4_cpuid_sync_test.c
vs.
Running make in kvm directory:
gcc -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99
-fno-stack-protector -fPIC -fno-PIE -I../../../../tools/include
-I../../../../usr/include/ -Iinclude -Ix86_64 -Iinclude/x86_64 -I..
-pthread -no-pie x86_64/cr4_cpuid_sync_test.c
I was playing with both options yesterday and totally confused myself
thinking that adding fPIC helps. It doesn't.
I am looking into this to see how we can make "make kselftest" work.
Once I figure it out, will send v2. I think for some reason in the
failing case, no-pie-option and pgste-option are null strings.
thanks,
-- Shuah
prev parent reply other threads:[~2019-09-25 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 20:14 [PATCH] selftests: kvm: Fix libkvm build error Shuah Khan
2019-09-25 7:48 ` Paolo Bonzini
2019-09-25 16:47 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fecb8a8-8a6a-1e2b-78e3-5660597a02e4@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).