From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAB14C433FE for ; Wed, 12 Oct 2022 15:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbiJLPoI (ORCPT ); Wed, 12 Oct 2022 11:44:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiJLPoH (ORCPT ); Wed, 12 Oct 2022 11:44:07 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D4EACAE52; Wed, 12 Oct 2022 08:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665589446; x=1697125446; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=XqAPHLBdMzTuuEY80fpMDDr2gQi/t6fzUUh5xjTnGyM=; b=JFQX0sabYdWaSWayxLe2Alhse/m+F9765VsnP4tgfIo/6yCAjTBfIcWO fPuNof3FFdPYtypKRBURPRqexvxXoVCHe0yvfP+FsxCQfR1qA77r7ZG53 26/PlaxLOBOaDWGIy1IHt/Z5NqFe5E8VpiaDQdI/SE6x/RBwv1s5/10iE OPdabFVPHkndVKBwCR2wRdUIREppWTWO5PagUkRFR6X+QgzeGq3Qzl71A SLTbN0GZRMYE8AVHb3ywGcEX7SYdXG5xQ6nezSdU5vOwdm3Ysf64qKYy8 szlKfRNLvk1KJ1YvEKbHcC0RStWBDa7WqLO0vGMCjAZv9E/usS+tnWs0X Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="391132231" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="391132231" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 08:44:05 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="695518334" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="695518334" Received: from jbrolli1-mobl.amr.corp.intel.com (HELO [10.212.174.189]) ([10.212.174.189]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 08:44:04 -0700 Message-ID: <6759025f-fc08-74f0-efd7-2331110dec0c@linux.intel.com> Date: Wed, 12 Oct 2022 08:44:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH v14 1/3] x86/tdx: Make __tdx_module_call() usable in driver module Content-Language: en-US To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Shuah Khan , Jonathan Corbet , "H . Peter Anvin" , Greg Kroah-Hartman , "Kirill A . Shutemov" , Tony Luck , Kai Huang , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org References: <20220928215535.26527-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220928215535.26527-2-sathyanarayanan.kuppuswamy@linux.intel.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/12/22 7:27 AM, Borislav Petkov wrote: > On Wed, Oct 12, 2022 at 06:35:56AM -0700, Sathyanarayanan Kuppuswamy wrote: >> So we should create a new wrapper for this use case or use > > Yes, you got it - a new wrapper pls. Ok. I will add a new wrapper to get the TDREPORT. +/* + * Add a wrapper for TDG.MR.REPORT TDCALL. It is used in TDX guest + * driver module to get the TDREPORT. + */ +long tdx_mcall_get_report(void *reportdata, void *tdreport, u8 subtype) +{ + if (subtype || !reportdata || !tdreport) + return -EINVAL; + + /* + * Generate TDREPORT using "TDG.MR.REPORT" TDCALL. + * + * Get the TDREPORT using REPORTDATA as input. Refer to + * section 22.3.3 TDG.MR.REPORT leaf in the TDX Module 1.0 + * specification for detailed information. + */ + return __tdx_module_call(TDX_GET_REPORT, virt_to_phys(tdreport), + virt_to_phys(reportdata), subtype, 0, NULL); +} +EXPORT_SYMBOL_GPL(tdx_mcall_get_report); > > Thx. > -- Sathyanarayanan Kuppuswamy Linux Kernel Developer