linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Documentation: kunit: Fix verification command
@ 2019-09-07 21:01 SeongJae Park
  2019-09-08 23:40 ` Brendan Higgins
  0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2019-09-07 21:01 UTC (permalink / raw)
  To: shuah, brendanhiggins, corbet
  Cc: linux-doc, linux-kselftest, kunit-dev, linux-kernel, SeongJae Park

kunit wrapper script ('kunit.py') receives a sub-command (only 'run' for
now) as its argument.  If no sub-command is given, it prints help
message and just quit.  However, an example command in the kunit
documentation for a verification of kunit is missing the sub-command.
This commit fixes the example.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 Documentation/dev-tools/kunit/start.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/dev-tools/kunit/start.rst b/Documentation/dev-tools/kunit/start.rst
index 6dc229e..aeeddfa 100644
--- a/Documentation/dev-tools/kunit/start.rst
+++ b/Documentation/dev-tools/kunit/start.rst
@@ -43,7 +43,7 @@ wrapper from your kernel repo:
 
 .. code-block:: bash
 
-	./tools/testing/kunit/kunit.py
+	./tools/testing/kunit/kunit.py run
 
 .. note::
    You may want to run ``make mrproper`` first.
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: kunit: Fix verification command
  2019-09-07 21:01 [PATCH] Documentation: kunit: Fix verification command SeongJae Park
@ 2019-09-08 23:40 ` Brendan Higgins
  2019-10-07 22:04   ` Brendan Higgins
  0 siblings, 1 reply; 4+ messages in thread
From: Brendan Higgins @ 2019-09-08 23:40 UTC (permalink / raw)
  To: SeongJae Park
  Cc: shuah, Jonathan Corbet, open list:DOCUMENTATION,
	open list:KERNEL SELFTEST FRAMEWORK, kunit-dev,
	Linux Kernel Mailing List

On Sat, Sep 7, 2019 at 2:01 PM SeongJae Park <sj38.park@gmail.com> wrote:
>
> kunit wrapper script ('kunit.py') receives a sub-command (only 'run' for
> now) as its argument.  If no sub-command is given, it prints help
> message and just quit.  However, an example command in the kunit
> documentation for a verification of kunit is missing the sub-command.
> This commit fixes the example.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

> ---
>  Documentation/dev-tools/kunit/start.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/dev-tools/kunit/start.rst b/Documentation/dev-tools/kunit/start.rst
> index 6dc229e..aeeddfa 100644
> --- a/Documentation/dev-tools/kunit/start.rst
> +++ b/Documentation/dev-tools/kunit/start.rst
> @@ -43,7 +43,7 @@ wrapper from your kernel repo:
>
>  .. code-block:: bash
>
> -       ./tools/testing/kunit/kunit.py
> +       ./tools/testing/kunit/kunit.py run

Ooops, that's embarrassing; I have the right command a couple lines above.

In anycase, thanks for finding and fixing this!

>  .. note::
>     You may want to run ``make mrproper`` first.
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: kunit: Fix verification command
  2019-09-08 23:40 ` Brendan Higgins
@ 2019-10-07 22:04   ` Brendan Higgins
  2019-10-07 23:06     ` shuah
  0 siblings, 1 reply; 4+ messages in thread
From: Brendan Higgins @ 2019-10-07 22:04 UTC (permalink / raw)
  To: SeongJae Park
  Cc: shuah, Jonathan Corbet, open list:DOCUMENTATION,
	open list:KERNEL SELFTEST FRAMEWORK, kunit-dev,
	Linux Kernel Mailing List

On Sun, Sep 8, 2019 at 4:40 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
>
> On Sat, Sep 7, 2019 at 2:01 PM SeongJae Park <sj38.park@gmail.com> wrote:
> >
> > kunit wrapper script ('kunit.py') receives a sub-command (only 'run' for
> > now) as its argument.  If no sub-command is given, it prints help
> > message and just quit.  However, an example command in the kunit
> > documentation for a verification of kunit is missing the sub-command.
> > This commit fixes the example.
> >
> > Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

Shuah, can you apply this to the kselftest KUnit branch? This should
not require a resend.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: kunit: Fix verification command
  2019-10-07 22:04   ` Brendan Higgins
@ 2019-10-07 23:06     ` shuah
  0 siblings, 0 replies; 4+ messages in thread
From: shuah @ 2019-10-07 23:06 UTC (permalink / raw)
  To: Brendan Higgins, SeongJae Park
  Cc: Jonathan Corbet, open list:DOCUMENTATION,
	open list:KERNEL SELFTEST FRAMEWORK, kunit-dev,
	Linux Kernel Mailing List, shuah

On 10/7/19 4:04 PM, Brendan Higgins wrote:
> On Sun, Sep 8, 2019 at 4:40 PM Brendan Higgins
> <brendanhiggins@google.com> wrote:
>>
>> On Sat, Sep 7, 2019 at 2:01 PM SeongJae Park <sj38.park@gmail.com> wrote:
>>>
>>> kunit wrapper script ('kunit.py') receives a sub-command (only 'run' for
>>> now) as its argument.  If no sub-command is given, it prints help
>>> message and just quit.  However, an example command in the kunit
>>> documentation for a verification of kunit is missing the sub-command.
>>> This commit fixes the example.
>>>
>>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>>
>> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> 
> Shuah, can you apply this to the kselftest KUnit branch? This should
> not require a resend.
> 


Done. Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git 
test

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-07 23:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-07 21:01 [PATCH] Documentation: kunit: Fix verification command SeongJae Park
2019-09-08 23:40 ` Brendan Higgins
2019-10-07 22:04   ` Brendan Higgins
2019-10-07 23:06     ` shuah

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).