linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Eugeniu Rosca <erosca@de.adit-jv.com>
Cc: "George G. Davis" <george_davis@mentor.com>,
	Eugeniu Rosca <roscaeugeniu@gmail.com>,
	Jerry Hoemann <jerry.hoemann@hpe.com>,
	Colin Ian King <colin.king@canonical.com>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	shuah <shuah@kernel.org>
Subject: Re: [PATCH v2] selftests: watchdog: Validate optional file argument
Date: Tue, 17 Sep 2019 09:25:31 -0600	[thread overview]
Message-ID: <73bab70b-e22c-42b4-cfca-b4e33431b423@kernel.org> (raw)
In-Reply-To: <20190917145400.GA14341@vmlxhi-102.adit-jv.com>

On 9/17/19 8:54 AM, Eugeniu Rosca wrote:
> Shuah,
> 
> On Mon, Sep 16, 2019 at 07:19:35PM -0600, shuah wrote:
>> On 9/16/19 12:49 PM, George G. Davis wrote:
>>> As reported by Eugeniu Rosca, a side of affect of commit c3f2490d6e92
>>> ("selftests: watchdog: Add optional file argument") is that arbitrary files
>>> may be opened for watchdog testing, e.g.
>>>
>>
>> You don't need to say this here since you are already have a
>> Reported-by tag.
> 
> This looks like asking people to stick to your personal taste which
> BTW doesn't really match the patterns established in Linux community.
> 
> With a bit of scripting, I am able to find around 4600 vanilla commits
> which happen to mention the name of the reporter in addition to
> Reported-by: https://paste.ubuntu.com/p/wNXfdGCJbX/ .
> 
> I really don't care if my name is mentioned once or twice, but I do
> believe that requesting a new patch revision just based on this criteria
> is nonsense. Can you please revise your review criteria?

I already said what I want. I want two patches and the first one with
Fixes tag. The reason for that is that the first patch fixes a problem
in patch that is already in my tree which is fixes a problem.

I am going to mark the patch for stables and the first patch in this
series.

I would like the commit log written clearly. Having a clear commit log
is a critical review comment. It is important for any change to have
clear commit logs for clarity and maintainability.

So please send me two patches one with Fixes tag and second that has
the -i support.

thanks,
-- Shuah



  reply	other threads:[~2019-09-17 15:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 18:49 [PATCH v2] selftests: watchdog: Validate optional file argument George G. Davis
2019-09-17  1:19 ` shuah
2019-09-17 14:54   ` Eugeniu Rosca
2019-09-17 15:25     ` shuah [this message]
2019-09-17 16:54       ` Eugeniu Rosca
2019-09-17 17:44         ` shuah
2019-09-17 17:50           ` Eugeniu Rosca
2019-09-17 18:05             ` shuah
2019-09-17 18:32               ` George G. Davis
2019-09-17 18:43                 ` George G. Davis
2019-09-17 18:51                   ` Eugeniu Rosca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73bab70b-e22c-42b4-cfca-b4e33431b423@kernel.org \
    --to=shuah@kernel.org \
    --cc=colin.king@canonical.com \
    --cc=erosca@de.adit-jv.com \
    --cc=george_davis@mentor.com \
    --cc=jerry.hoemann@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=roscaeugeniu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).