From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kselftest@vger.kernel.org
Cc: catalin.marinas@arm.com, will@kernel.org, paul.burton@mips.com,
salyzyn@android.com, 0x7f454c46@gmail.com, luto@kernel.org
Subject: Re: [PATCH v2 2/8] lib: vdso: Build 32 bit specific functions in the right context
Date: Tue, 14 Jan 2020 11:15:23 +0000 [thread overview]
Message-ID: <7453d44d-9901-d826-b19d-f7ff22d5b89d@arm.com> (raw)
In-Reply-To: <87muaqqq62.fsf@nanos.tec.linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2946 bytes --]
Hi Thomas,
On 14/01/2020 10:37, Thomas Gleixner wrote:
> Vincenzo Frascino <vincenzo.frascino@arm.com> writes:
>>
>> On 14/01/2020 09:33, Thomas Gleixner wrote:
>>> Thomas Gleixner <tglx@linutronix.de> writes:
>>>
>> [...]
>>
>>>
>>> Bah, it's not fixing it. That's what you get when you compile the wrong
>>> tree...
>
> This part is required to cover the BUILD_VDSO32 guard, but then when the
> fallback thing is removed it fails again because the 32bit fallbacks are
> missing.
>
> The patch below makes it build again.
I completed the testing and everything seems fine. For completeness I am
reporting the test results below:
clock-gettime-monotonic: syscall: 938 nsec/call
clock-gettime-monotonic: libc: 278 nsec/call
clock-gettime-monotonic: vdso: 270 nsec/call
clock-getres-monotonic: syscall: 678 nsec/call
clock-getres-monotonic: libc: 692 nsec/call
clock-getres-monotonic: vdso: 33 nsec/call
clock-gettime-monotonic-coarse: syscall: 840 nsec/call
clock-gettime-monotonic-coarse: libc: 184 nsec/call
clock-gettime-monotonic-coarse: vdso: 172 nsec/call
clock-getres-monotonic-coarse: syscall: 710 nsec/call
clock-getres-monotonic-coarse: libc: 733 nsec/call
clock-getres-monotonic-coarse: vdso: 35 nsec/call
clock-gettime-monotonic-raw: syscall: 894 nsec/call
clock-gettime-monotonic-raw: libc: 278 nsec/call
clock-gettime-monotonic-raw: vdso: 270 nsec/call
clock-getres-monotonic-raw: syscall: 669 nsec/call
clock-getres-monotonic-raw: libc: 696 nsec/call
clock-getres-monotonic-raw: vdso: 35 nsec/call
clock-gettime-tai: syscall: 933 nsec/call
clock-gettime-tai: libc: 277 nsec/call
clock-gettime-tai: vdso: 264 nsec/call
clock-getres-tai: syscall: 674 nsec/call
clock-getres-tai: libc: 696 nsec/call
clock-getres-tai: vdso: 33 nsec/call
clock-gettime-boottime: syscall: 934 nsec/call
clock-gettime-boottime: libc: 278 nsec/call
clock-gettime-boottime: vdso: 270 nsec/call
clock-getres-boottime: syscall: 677 nsec/call
clock-getres-boottime: libc: 690 nsec/call
clock-getres-boottime: vdso: 33 nsec/call
clock-gettime-realtime: syscall: 901 nsec/call
clock-gettime-realtime: libc: 278 nsec/call
clock-gettime-realtime: vdso: 272 nsec/call
clock-getres-realtime: syscall: 677 nsec/call
clock-getres-realtime: libc: 701 nsec/call
clock-getres-realtime: vdso: 33 nsec/call
clock-gettime-realtime-coarse: syscall: 838 nsec/call
clock-gettime-realtime-coarse: libc: 184 nsec/call
clock-gettime-realtime-coarse: vdso: 172 nsec/call
clock-getres-realtime-coarse: syscall: 713 nsec/call
clock-getres-realtime-coarse: libc: 736 nsec/call
clock-getres-realtime-coarse: vdso: 35 nsec/call
getcpu: syscall: 620 nsec/call
getcpu: libc: 648 nsec/call
gettimeofday: syscall: 1022 nsec/call
gettimeofday: libc: 280 nsec/call
gettimeofday: vdso: 272 nsec/call
--
Regards,
Vincenzo
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]
next prev parent reply other threads:[~2020-01-14 11:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 13:58 [PATCH v2 0/8] vdso: Complete the conversion to 32bit syscalls Vincenzo Frascino
2019-08-30 13:58 ` [PATCH v2 1/8] arm64: compat: vdso: Expose BUILD_VDSO32 Vincenzo Frascino
2019-09-03 14:36 ` Vincenzo Frascino
2019-09-03 14:38 ` Will Deacon
2019-08-30 13:58 ` [PATCH v2 2/8] lib: vdso: Build 32 bit specific functions in the right context Vincenzo Frascino
2020-01-13 22:28 ` Thomas Gleixner
2020-01-14 9:33 ` Thomas Gleixner
2020-01-14 10:15 ` Vincenzo Frascino
2020-01-14 10:37 ` Thomas Gleixner
2020-01-14 10:41 ` Vincenzo Frascino
2020-01-14 11:15 ` Vincenzo Frascino [this message]
2019-08-30 13:58 ` [PATCH v2 3/8] mips: compat: vdso: Use legacy syscalls as fallback Vincenzo Frascino
2019-09-03 13:52 ` Paul Burton
2019-09-03 14:20 ` Vincenzo Frascino
2019-09-03 21:00 ` Paul Burton
2019-08-30 13:58 ` [PATCH v2 4/8] lib: vdso: Remove VDSO_HAS_32BIT_FALLBACK Vincenzo Frascino
2019-08-30 13:58 ` [PATCH v2 5/8] lib: vdso: Remove checks on return value for 32 bit vDSO Vincenzo Frascino
2019-08-30 14:16 ` Vincenzo Frascino
2019-08-30 13:59 ` [PATCH v2 6/8] arm64: compat: vdso: Remove unused VDSO_HAS_32BIT_FALLBACK Vincenzo Frascino
2019-08-30 13:59 ` [PATCH v2 7/8] mips: " Vincenzo Frascino
2019-09-03 14:46 ` Paul Burton
2019-09-03 14:51 ` Vincenzo Frascino
2019-08-30 13:59 ` [PATCH v2 8/8] x86: " Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7453d44d-9901-d826-b19d-f7ff22d5b89d@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=0x7f454c46@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=luto@kernel.org \
--cc=paul.burton@mips.com \
--cc=salyzyn@android.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).