From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8F63C43331 for ; Thu, 26 Mar 2020 20:17:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F0E22083E for ; Thu, 26 Mar 2020 20:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585253822; bh=gjdhbmH2QaYiDn8/j5vQaISgUmsqEDdrXvfY7uAJWc0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=DFKReRKwFw4MJt0t8nZvyhN9VB+qWmogaK3soIYsWh+1EWgY3+VjdThxSMwye2ARv E+UYJUzSo0rDxCjAymUnDI5iySawujgZBjuZgFaqfT/4edBuGslnes9FB+zY0Btyk0 soxRTIgxyePdzOZUPVkAOdMMKTWRP5npKv+0SE8Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728317AbgCZURC (ORCPT ); Thu, 26 Mar 2020 16:17:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:39452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727943AbgCZURC (ORCPT ); Thu, 26 Mar 2020 16:17:02 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B1352070A; Thu, 26 Mar 2020 20:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585253821; bh=gjdhbmH2QaYiDn8/j5vQaISgUmsqEDdrXvfY7uAJWc0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=koGo9Lz4CXJCY0y8wLdk3XvEDjTOqDEL/26t2CTEstAlsZ1Z8NcURi5OfmCZgHywV x2InR0PnUjGa9o0YCvV96D6FKOV7949BfhPlohR6b9BWmr9Ciaapq0pEHmL9T0uX7k 4gLPGSVqPknjBfJvxFt9rcKnSCVrUgLllYaNVKik= Subject: Re: [PATCH v2] kunit: tool: add missing test data file content To: David Gow , Brendan Higgins Cc: Heidi Fahim , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , shuah References: <20200323192236.70152-1-brendanhiggins@google.com> From: shuah Message-ID: <75c33274-68e6-6ad4-c4a8-0dc9b14a9af6@kernel.org> Date: Thu, 26 Mar 2020 14:17:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 3/23/20 8:56 PM, David Gow wrote: > On Mon, Mar 23, 2020 at 12:22 PM Brendan Higgins > wrote: >> >> Add a missing raw dmesg test log to test the kunit_tool's dmesg parser. >> test_prefix_poundsign and test_output_with_prefix_isolated_correctly >> fail without this test log. >> >> Signed-off-by: Brendan Higgins > > Tested-by: David Gow > > This patch does indeed fix the kunit_tool's unit tests (run with > ./tools/testing/kunit/kunit_tool_test.py). > > Beforehand, it failed with the errors below: > ====================================================================== > ERROR: test_prefix_poundsign (__main__.KUnitParserTest) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "./tools/testing/kunit/kunit_tool_test.py", line 208, in > test_prefix_poundsign > self.assertEqual('kunit-resource-test', result.suites[0].name) > IndexError: list index out of range > > ====================================================================== > FAIL: test_output_with_prefix_isolated_correctly > (__main__.KUnitParserTest) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "./tools/testing/kunit/kunit_tool_test.py", line 116, in > test_output_with_prefix_isolated_correctly > self.assertContains('TAP version 14\n', result) > File "./tools/testing/kunit/kunit_tool_test.py", line 96, in > assertContains > str(needle) + '" not found in "' + str(haystack) + '"!') > AssertionError: "TAP version 14 > " not found in ""! > > ---------------------------------------------------------------------- > Ran 20 tests in 0.022s > > FAILED (failures=1, errors=1) > Applied to linux-kselftest kunit for Linux 5.7-rc1. thanks, -- Shuah