From: Xiaoyao Li <xiaoyao.li@intel.com>
To: shuah <shuah@kernel.org>, Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v3 0/3] Fix errors when try to build kvm selftests on specified output
Date: Sat, 28 Mar 2020 16:51:47 +0800 [thread overview]
Message-ID: <77ad35cf-6332-9381-200e-40b6a3d18070@intel.com> (raw)
In-Reply-To: <71a5abdf-07b5-d927-1a08-de8019b3f39f@kernel.org>
On 3/28/2020 12:03 AM, shuah wrote:
> On 3/27/20 7:31 AM, Xiaoyao Li wrote:
>> On 3/27/2020 4:57 AM, shuah wrote:
>>> On 3/25/20 9:07 PM, Xiaoyao Li wrote:
> The patches you sent are based on running the command with OUTPUT
> set.
The issues are also there when I use
make O=/somewher TARGETS=kvm
from tools/testing/selftests/ directory,
Is it the right usecase?
> That is why I am asking you start with the right use-cases,
> and gave you pointers on tests to refer to that have sub-dirs
> and handle relocatable builds:
>
> futex
> arm64
> android
I have read the Makefile in futex, arm64, android to learn how they
deal with subdir, they have Makefile in subdir but kvm doesn't.
I just want to create the subdir as easy as possible, so I follow the
method how to create subdir for LIBKVM_OBJ in kvm.
If you dislike it way you can reply it Patch 1 to disclaim clear what
you want to fix the subdir.
>>> Also, just build isn't sufficient for you to be able to run the
>>> tests.
>>>
>>> make kselftest-install O=/path/to/mydir TARGETS=kvm will generate
>>> run script.
>>
>> This command also has the x86_64 directory not created issue.
>> Since it generates header files in kernel_src/usr/include, it doesn't
>> have headers path issue. But as result, the kernel_src directory is
>> not clean, this requires me to run "make mrproper", I *really* don't
>> like it.
>>
>>
>
> If the test leverages lib.mk headers install logic correctly, you
> shouldn't see this problem.
>
> Yes. It does make the source directory dirty. That is the problem we
> have to fix. I am seeing issues the issue of x86_64 not being created
> in the case of relocatable builds.
>
> Thanks for working on this by the way. It is one of the tests that
> identified as the one doesn't support relocatable builds.
>
> You will see fixes to others I already fixed in
>
> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next
>
>
> Start withe the following use0-cases to fix and then test your fixes
> for these use-cases. The goal is to be able to run kvm from target
> directory and source directory staying clean.
>
> You will have to build the kernel first in all of these cases.
> Let's use kselftest-install which is what you would need if you
> want build and then run tests later. Also assuming you are doing
> native build on x86_64.
>
> From main kernel Makefile: (from kernel source root dir)
>
> Builds in the same source directory:
> make kselftest-install TARGETS=kvm
>
> Relocatable build: (from kernel source root dir)
>
> make O=/path/objdir - build kernel
> make kselftest-install O=/path/objdir TARGETS=kvm
I don't want to build kernel at all.
> From tools/testing/selftests/kvm directory:
> make O=/path/objdir install
Oh no. This needs to define INSTALL_PATH, and I don't want to install.
I just want to build the testcase of kvm to anywhere else to make srcdir
clean.
Besides this command make both kernel src and selftest/kvm dirty.
> Install step is important especially for relocatable builds,
> as it makes sure all run-time dependencies are copied to the
> target directory.
>
OK.
So, again.
is
make O=/tmp/kvm-selftest -C tools/testing/selftests \
TARGETS=kvm install INSTALL_PATH=/home/lxy/kvm-selftest
the right command for me to start on?
next prev parent reply other threads:[~2020-03-28 8:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 3:07 [RFC v3 0/3] Fix errors when try to build kvm selftests on specified output Xiaoyao Li
2020-03-26 3:07 ` [RFC v3 1/3] kvm: selftests: Fix no directory error when OUTPUT specified Xiaoyao Li
2020-03-26 3:07 ` [RFC v3 2/3] kvm: selftests: Use the right INSTALL_HDR_PATH when OUTPUT specified and MAKELEVEL is 0 Xiaoyao Li
2020-03-26 3:07 ` [RFC v3 3/3] kvm: selftests: Fix header path when built from parent level with O specified Xiaoyao Li
2020-03-26 20:57 ` [RFC v3 0/3] Fix errors when try to build kvm selftests on specified output shuah
2020-03-27 13:31 ` Xiaoyao Li
2020-03-27 16:03 ` shuah
2020-03-28 8:51 ` Xiaoyao Li [this message]
2020-05-01 17:11 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77ad35cf-6332-9381-200e-40b6a3d18070@intel.com \
--to=xiaoyao.li@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).