From: Shuah Khan <skhan@linuxfoundation.org>
To: Yang Xu <xuyang2018.jy@fujitsu.com>,
linux-kselftest@vger.kernel.org, shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org,
aleksei.kodanev@bell-sw.com,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 3/3] selftests/zram: Adapt the situation that /dev/zram0 is being used
Date: Tue, 25 Jan 2022 13:40:25 -0700 [thread overview]
Message-ID: <7ec24b9a-4b98-ca31-9862-4b2d2df4b50e@linuxfoundation.org> (raw)
In-Reply-To: <1639562171-4434-3-git-send-email-xuyang2018.jy@fujitsu.com>
On 12/15/21 2:56 AM, Yang Xu wrote:
> On some linux distributions, if it used /dev/zram0 as default by zram-generate
> service, then this case will fail or report EBUSY.
>
> To fix this, use hot_add/hot_remove interface. Also, move module check code into
> zram_load from zram.sh. We can use /sys/class/zram-control to detect the
> module whether existed.
>
> After this patch, we still run case pass even /dev/zram0 is being used.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
> tools/testing/selftests/zram/zram.sh | 16 +----
> tools/testing/selftests/zram/zram01.sh | 2 +-
> tools/testing/selftests/zram/zram_lib.sh | 75 ++++++++++++------------
> 3 files changed, 41 insertions(+), 52 deletions(-)
>
This patch looks good to me. A few checkpatch warns to fix and also
it probably depends on the other two patches in this series.
Please fix and send v2 for all 3 patches.
thanks,
-- Shuah
next prev parent reply other threads:[~2022-01-25 20:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 9:56 [PATCH 1/3] selftests/zram: Remove obsolete max_comp_streams interface Yang Xu
2021-12-15 9:56 ` [PATCH 2/3] selftests/zram01.sh: Fix compression ratio calculation Yang Xu
2022-01-25 20:37 ` Shuah Khan
2022-01-26 6:08 ` xuyang2018.jy
2021-12-15 9:56 ` [PATCH 3/3] selftests/zram: Adapt the situation that /dev/zram0 is being used Yang Xu
2022-01-25 20:40 ` Shuah Khan [this message]
2022-01-13 6:26 ` [PATCH 1/3] selftests/zram: Remove obsolete max_comp_streams interface xuyang2018.jy
2022-01-25 20:52 ` Shuah Khan
2022-01-25 20:33 ` Shuah Khan
2022-01-26 5:19 ` xuyang2018.jy
2022-01-26 7:13 ` Petr Vorel
2022-01-26 17:35 ` Shuah Khan
2022-01-26 18:24 ` Petr Vorel
2022-01-26 18:37 ` Shuah Khan
2022-01-27 9:11 ` [PATCH v2 1/3] selftests/zram: Skip max_comp_streams interface on newer kernel Yang Xu
2022-01-27 9:11 ` [PATCH v2 2/3] selftests/zram01.sh: Fix compression ratio calculation Yang Xu
2022-01-27 9:11 ` [PATCH v2 3/3] selftests/zram: Adapt the situation that /dev/zram0 is being used Yang Xu
2022-01-27 18:05 ` [PATCH v2 1/3] selftests/zram: Skip max_comp_streams interface on newer kernel Shuah Khan
2022-01-28 1:17 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ec24b9a-4b98-ca31-9862-4b2d2df4b50e@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=aleksei.kodanev@bell-sw.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=shuah@kernel.org \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).