From: Scott Branden <scott.branden@broadcom.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Brown <david.brown@linaro.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Shuah Khan <shuah@kernel.org>,
bjorn.andersson@linaro.org,
Shuah Khan <skhan@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Olof Johansson <olof@lixom.net>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Colin Ian King <colin.king@canonical.com>,
Kees Cook <keescook@chromium.org>, Takashi Iwai <tiwai@suse.de>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/7] firmware: add offset to request_firmware_into_buf
Date: Thu, 22 Aug 2019 13:07:41 -0700 [thread overview]
Message-ID: <7ee02971-e177-af05-28e0-90575ebe12e0@broadcom.com> (raw)
In-Reply-To: <20190822194712.GG16384@42.do-not-panic.com>
Hi Luis,
On 2019-08-22 12:47 p.m., Luis Chamberlain wrote:
> On Thu, Aug 22, 2019 at 12:24:46PM -0700, Scott Branden wrote:
>> @@ -923,16 +936,22 @@ EXPORT_SYMBOL_GPL(firmware_request_cache);
>> */
>> int
>> request_firmware_into_buf(const struct firmware **firmware_p, const char *name,
>> - struct device *device, void *buf, size_t size)
>> + struct device *device, void *buf, size_t size,
>> + size_t offset, unsigned int pread_flags)
> This implies you having to change the other callers, and while currently
> our list of drivers is small,
Yes, the list is small, very small.
There is a single driver making a call to the existing API.
And, the existing API was never tested until I submitted a test case.
And, the maintainer of that driver wanted
to start utilizing my enhanced API instead of the current API.
As such I think it is very reasonable to update the API right now.
> following the history of the firmware API
> and the long history of debate of *how* we should evolve its API, its
> preferred we add yet another new caller for this functionality. So
> please add a new caller, and use EXPORT_SYMBOL_GPL().
>
> And while at it, pleaase use firmware_request_*() as the prefix, as we
> have want to use that as the instilled prefix. We have yet to complete
> the rename of the others older callers but its just a matter of time.
>
> So something like: firmware_request_into_buf_offset()
I would prefer to rename the API at this time given there is only a
single user.
Otherwise I would need to duplicate quite a bit in the test code to
support testing
the single user of the old api and then enhanced API.
Or, I can leave existing API in place and change the test case to
just test the enhanced API to keep things simpler in the test code?
>
> And thanks for adding a test case!
>
> Luis
Regards,
Scott
next prev parent reply other threads:[~2019-08-22 20:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 19:24 [PATCH 0/7] firmware: add partial read support in request_firmware_into_buf Scott Branden
2019-08-22 19:24 ` [PATCH 1/7] fs: introduce kernel_pread_file* support Scott Branden
2019-08-23 12:29 ` Takashi Iwai
2019-08-23 19:55 ` Scott Branden
2019-08-23 21:29 ` Luis Chamberlain
2019-08-22 19:24 ` [PATCH 2/7] firmware: add offset to request_firmware_into_buf Scott Branden
2019-08-22 19:47 ` Luis Chamberlain
2019-08-22 20:07 ` Scott Branden [this message]
2019-08-22 21:12 ` Luis Chamberlain
2019-08-22 23:30 ` Scott Branden
2019-08-23 15:47 ` Luis Chamberlain
2019-08-23 20:16 ` Scott Branden
2019-08-23 10:05 ` Takashi Iwai
2019-08-23 19:44 ` Scott Branden
2019-08-26 15:20 ` Takashi Iwai
2019-08-26 15:41 ` Scott Branden
2019-08-26 15:57 ` Takashi Iwai
2019-08-26 17:12 ` Takashi Iwai
2019-08-26 17:24 ` Scott Branden
2019-08-27 10:40 ` Takashi Iwai
2019-10-11 13:31 ` Luis Chamberlain
2020-02-21 0:11 ` Scott Branden
2020-02-21 8:44 ` Arnd Bergmann
2020-02-21 18:23 ` Scott Branden
2020-02-21 23:37 ` Scott Branden
2020-02-22 8:06 ` Arnd Bergmann
2019-08-22 19:24 ` [PATCH 3/7] test_firmware: add partial read support for request_firmware_into_buf Scott Branden
2019-08-22 19:24 ` [PATCH 4/7] selftests: firmware: Test partial file reads of request_firmware_into_buf Scott Branden
2019-08-22 19:24 ` [PATCH 5/7] bcm-vk: add bcm_vk UAPI Scott Branden
2019-08-27 13:54 ` Arnd Bergmann
2019-08-27 14:49 ` Kieran Bingham
2019-10-08 15:59 ` Olof Johansson
2019-08-22 19:24 ` [PATCH 6/7] misc: bcm-vk: add Broadcom Valkyrie driver Scott Branden
2019-08-27 14:14 ` Arnd Bergmann
2019-08-27 15:25 ` Nicolas Dufresne
2019-08-22 19:24 ` [PATCH 7/7] MAINTAINERS: bcm-vk: Add maintainer for Broadcom Valkyrie Driver Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee02971-e177-af05-28e0-90575ebe12e0@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=olof@lixom.net \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).