From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C96C74A2B for ; Wed, 10 Jul 2019 15:54:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F39682064A for ; Wed, 10 Jul 2019 15:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727552AbfGJPyB (ORCPT ); Wed, 10 Jul 2019 11:54:01 -0400 Received: from foss.arm.com ([217.140.110.172]:35812 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfGJPyA (ORCPT ); Wed, 10 Jul 2019 11:54:00 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB7602B; Wed, 10 Jul 2019 08:53:59 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 220293F246; Wed, 10 Jul 2019 08:53:57 -0700 (PDT) Subject: Re: [PATCH v2] arm64: vdso: Fix ABI regression in compat vdso To: John Stultz Cc: linux-arch@vger.kernel.org, linux-arm-kernel , lkml , linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, Catalin Marinas , Will Deacon , Arnd Bergmann , Russell King - ARM Linux , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Huw Davies , Shijith Thotton , Andre Przywara , Andy Lutomirski References: <20190621095252.32307-11-vincenzo.frascino@arm.com> <20190710140119.23417-1-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: <7fc94d97-3cff-c983-ad63-e61f118e2936@arm.com> Date: Wed, 10 Jul 2019 16:53:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi John, On 10/07/2019 16:44, John Stultz wrote: > On Wed, Jul 10, 2019 at 7:01 AM Vincenzo Frascino > wrote: >> >> Prior to the introduction of Unified vDSO support and compat layer for >> vDSO on arm64, AT_SYSINFO_EHDR was not defined for compat tasks. >> In the current implementation, AT_SYSINFO_EHDR is defined even if the >> compat vdso layer is not built and this causes a regression in the >> expected behavior of the ABI. >> >> Restore the ABI behavior making sure that AT_SYSINFO_EHDR for compat >> tasks is defined only when CONFIG_COMPAT_VDSO is enabled. >> >> Reported-by: John Stultz >> Signed-off-by: Vincenzo Frascino > > This seems to solve it for me! > Thanks so much for the quick turnaround on a fix. I really appreciate it! > > Tested-by: John Stultz > Thank you for the quick reply, it means I can go home early today ;-) > thanks > -john > -- Regards, Vincenzo