From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 741A6C433EF for ; Tue, 19 Jul 2022 17:31:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239334AbiGSRby (ORCPT ); Tue, 19 Jul 2022 13:31:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239577AbiGSRbu (ORCPT ); Tue, 19 Jul 2022 13:31:50 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 984DA5A885; Tue, 19 Jul 2022 10:31:49 -0700 (PDT) Received: from [192.168.1.72] (136.203.115.78.rev.sfr.net [78.115.203.136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: gtucker) by madras.collabora.co.uk (Postfix) with ESMTPSA id 329456601955; Tue, 19 Jul 2022 18:31:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658251907; bh=jIA5oD7gpTgXWAfR2Mm2w19/e/vskjL1LF249/HQPKo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XMqXepdPgkUEe+ogPiW5sOOGjTJFuh6/M+BipmxwVp3FCwN7dpsUWnWnAUEhR18Pr IEJGPkx05XNPQW+iy+mj455M9z2dBSwFX7gb7RdXIoMZFq4I5/GF4iOpO+NA/pTRvg dTgUg+EpRKJVBVj2vfB1PsUzsaIWrAXOvvNx4yFCwnks9erHHkRtGjXCl+RZHcNRE2 3wZcbfqg4rK1pm26yBuaXP5Mvb4HNbHc1R2xR5n/RHUFUXh8NxRj87oCpkfHf8Kum+ YCTY/Imwu0T0nLGfwQpxznP8WyhtB1glBCo6LeW3/vkRDwUGYjH2JQPxhWfV3kTrH5 RBZhOR6FRgaNg== Message-ID: <81241d70-7952-2f55-9181-d18679068998@collabora.com> Date: Tue, 19 Jul 2022 19:31:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] Makefile: replace headers_install with headers for kselftest Content-Language: en-US To: Masahiro Yamada , Shuah Khan Cc: Michal Marek , Nick Desaulniers , Shuah Khan , Kees Cook , Anders Roxell , Tim Bird , kernel@collabora.com, Linux Kbuild mailing list , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" References: <8fc9d169-78ff-0fe4-67c0-784097861f12@collabora.com> From: Guillaume Tucker In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 19/07/2022 17:06, Masahiro Yamada wrote: > On Tue, Jul 19, 2022 at 9:37 PM Guillaume Tucker > wrote: >> >> On 14/07/2022 22:45, Shuah Khan wrote: >>> On 7/13/22 12:33 AM, Guillaume Tucker wrote: >>>> Replace headers_install with headers as kselftest uses the header >>>> files from within the kernel tree rather than from a system-wide >>>> installation. >>>> >>>> We can still run this directly: >>>> >>>> $ make O=build kselftest-all >>>> >>>> and when building from the selftests directory: >>>> >>>> $ make O=build headers >>>> $ make O=build -C tools/testing/selftests all >>>> >>>> Signed-off-by: Guillaume Tucker >>>> Reported-by: Masahiro Yamada >>>> --- >>>> Makefile | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Makefile b/Makefile >>>> index fb2f3bb53a6b..5c934d16664c 100644 >>>> --- a/Makefile >>>> +++ b/Makefile >>>> @@ -1347,10 +1347,10 @@ tools/%: FORCE >>>> # Kernel selftest >>>> PHONY += kselftest >>>> -kselftest: headers_install >>>> +kselftest: headers >>>> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests >>>> -kselftest-%: headers_install FORCE >>>> +kselftest-%: headers FORCE >>>> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $* >>>> PHONY += kselftest-merge >>>> >>> >>> Thank you for taking care of this. This will go through kbuild? >> >> You're welcome. >> >> Masahiro-san, >> >> A you OK with applying this in the kbuild tree ahead of the >> upcoming merge window? > > > No. > > This is a fix-up patch on top of the previous one [1], > which was applied to the kselftest tree. > > This cannot apply to the kbuild tree. OK thank you for confirming. Shuah, I guess you're happy to apply it to the kselftest tree instead then? Guillaume > [1]: https://lore.kernel.org/linux-kbuild/168ede35-12e0-c535-9d94-23b65a1beb28@collabora.com/T/#mb8ec7004f7c9b89fbb50c19022760e19701af7f6 > > > > > > >> Best wishes, >> Guillaume >> >>> Acked-by: Shuah Khan >>> >>> thanks, >>> -- Shuah >>> > > >