From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91133C5ACC4 for ; Thu, 20 Feb 2020 01:04:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6529721D56 for ; Thu, 20 Feb 2020 01:04:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Y2F8BNU9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbgBTBEp (ORCPT ); Wed, 19 Feb 2020 20:04:45 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:37714 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726841AbgBTBEo (ORCPT ); Wed, 19 Feb 2020 20:04:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=3BHL21ZqYvf4cXWBd1/ab6+pZgwMbOograui/t2in4Q=; b=Y2F8BNU9IGvys2N2MQOenMYNwp +IrnfcmBH0shv9ZUFezaJBrOrMWeJ56kYqWE/S2Co2mp3i1dhZ7D41EsTGAV/yzAHp6kmpl8pMx4y Vz+b2TRxJIDtn63xKBdI/AxAsIUmmRSsdA0yrfu2DcbWpKDkCNyl11/OByWqIF3rNO4EpuEqokqvl A+cSkuI1maBCBJMyQexlSpmMIWzduXQ5i5x6IDABAtR/jrqMXVlFPWizsED2mb2ICNUcnpIu4sfhS DlNmlg3WSV+qRWWX67zw3p/LatenkuXdRZMB4pl0HHOBu8MAy/7r98fbw0e+OLYch2F8b73oqiTyz XcLFyvyA==; Received: from [2603:3004:32:9a00::4074] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4aGe-0002wj-9E; Thu, 20 Feb 2020 01:04:40 +0000 Subject: Re: [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver To: Scott Branden , Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann Cc: "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , Desmond Yan , James Hu References: <20200220004825.23372-1-scott.branden@broadcom.com> <20200220004825.23372-7-scott.branden@broadcom.com> From: Randy Dunlap Message-ID: <827a4520-95ce-5264-90d9-ed730e5918e6@infradead.org> Date: Wed, 19 Feb 2020 17:04:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200220004825.23372-7-scott.branden@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi, On 2/19/20 4:48 PM, Scott Branden wrote: > diff --git a/drivers/misc/bcm-vk/Kconfig b/drivers/misc/bcm-vk/Kconfig > new file mode 100644 > index 000000000000..c75dfb89a38d > --- /dev/null > +++ b/drivers/misc/bcm-vk/Kconfig > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Broadcom VK device > +# > +config BCM_VK > + tristate "Support for Broadcom VK Accelerators" > + depends on PCI_MSI > + default m Need to justify default m. Normally we don't add drivers as enabled unless they are required for basic (boot) operation. > + help > + Select this option to enable support for Broadcom > + VK Accelerators. VK is used for performing > + specific video offload processing. This driver enables > + userspace programs to access these accelerators via /dev/bcm-vk.N > + devices. > + > + If unsure, say N. > + > +if BCM_VK > + > +config BCM_VK_H2VK_VERIFY_AND_RETRY > + bool "Host To VK Verifiy Data and Retry" Verify > + help > + Turn on to verify the data passed down to VK is good, > + and if not, do a retry until it succeeds. No timeout on that retry? > + This is a debug/workaround on FPGA PCIe timing issues > + but may be found useful for debugging other PCIe hardware issues. > + Small performance loss by enabling this debug config. > + For properly operating PCIe hardware no need to enable this. > + > + If unsure, say N. > + > +config BCM_VK_QSTATS > + bool "VK Queue Statistics" > + help > + Turn on to enable Queue Statistics. > + These are useful for debugging purposes. > + Some performance loss by enabling this debug config. > + For properly operating PCIe hardware no need to enable this. > + > + If unsure, say N. > + > +endif cheers. -- ~Randy