linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	David Gow <davidgow@google.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
	Kees Cook <keescook@chromium.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	shuah <shuah@kernel.org>
Subject: Re: [PATCH linux-kselftest/test v2] lib/list-test: add a test for the 'list' doubly linked list
Date: Fri, 18 Oct 2019 15:24:46 -0600	[thread overview]
Message-ID: <84f0b15f-f451-fce7-1ab2-1ecdf740c864@kernel.org> (raw)
In-Reply-To: <20191016173233.2bd9c9d47f12453c1cb4a9b7@linux-foundation.org>

On 10/16/19 6:32 PM, Andrew Morton wrote:
> On Wed, 16 Oct 2019 14:48:59 -0700 David Gow <davidgow@google.com> wrote:
> 
>> Since KUnit is not yet in Linus' branch, though, it probably makes
>> sense to put this test into the linux-kselftest/test branch, so that
>> there aren't any chances of the list test getting in without the KUnit
>> infrastructure. Ultimately, once KUnit is upstream, this shouldn't be
>> an issue, but it is probably easier to consolidate things for now.
>> Does that sound sensible?
> 
> Well, whatever.  I have a note that it's dependent on kunit.
> 
David and Andrew,

I have a few comments on CONFIG naming to be consistent with the other
kunit ext4 test and a couple of other comments that would requite v3.

I would like to bundle these in the pull request with KUnit framework.
Hope that is okay with you.

thanks,
-- Shuah



  reply	other threads:[~2019-10-18 21:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 18:56 [PATCH linux-kselftest/test v2] lib/list-test: add a test for the 'list' doubly linked list David Gow
2019-10-11 21:05 ` Andrew Morton
2019-10-11 21:07 ` Andrew Morton
2019-10-11 21:37   ` David Gow
2019-10-11 21:55     ` Andrew Morton
2019-10-16 20:48       ` Brendan Higgins
2019-10-16 21:48       ` David Gow
2019-10-17  0:32         ` Andrew Morton
2019-10-18 21:24           ` shuah [this message]
2019-10-18 21:21 ` shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84f0b15f-f451-fce7-1ab2-1ecdf740c864@kernel.org \
    --to=shuah@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=keescook@chromium.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).