From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 296B9C432C0 for ; Thu, 28 Nov 2019 04:17:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2701215F2 for ; Thu, 28 Nov 2019 04:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="WjtXk+D2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727175AbfK1ERX (ORCPT ); Wed, 27 Nov 2019 23:17:23 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:41701 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727113AbfK1ERX (ORCPT ); Wed, 27 Nov 2019 23:17:23 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 47Nkr041S7z9sPh; Thu, 28 Nov 2019 15:17:20 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1574914641; bh=VEyyPP4HvO8k4r9mELIjMEJj5VIL+iMWnQDGCO2SKMs=; h=From:To:Subject:In-Reply-To:References:Date:From; b=WjtXk+D2/h6cMNvjuIQxPCYQCzHu0Dfruk0iswtYUczPpEvxkC+egvFtzZhvn3j5S 1HMZEq1QSCleidlsS5WVivv+1I61nIPL7iEjbbf8xgrzLCSWlEINddLYygxnZ6nxxL 5Fpb8gieuqwvwWBk9NueoFHBcHssyo2Wrr/u5YqWiITQCGhxTbLAbNcFDfGOPPUY6V HAFkL3DZW9CmdVVBo6pTvyh/7YCYmVxeJoNR60L0WJo7UWKNLx2yJpHNpsI8mwtrzv 0P//e+X4ucGMACxlursR4j6Y91yGBwtReCcIhDXgMgnzz7AsNm6c4lyrxA++food05 mTgBxO8Xov+Kg== From: Michael Ellerman To: Tim.Bird@sony.com, shuah@kernel.org, cristian.marussi@arm.com, linux-kselftest@vger.kernel.org Subject: RE: kselftest: failed to build with -C tool/testing/selftests when KBUILD_OUTPUT is set In-Reply-To: References: <8d34a9b9-f8f3-0e37-00bf-c342cf3d4074@arm.com> <8736ea2cty.fsf@mpe.ellerman.id.au> <47e09faa-a3fb-04a7-4989-4443b27f47c2@arm.com> <8bd66a2d-e92f-6108-77d0-91d737df9b0d@kernel.org> <3f436c1b-1921-78f7-c021-9c8472e24733@arm.com> <2fa5f914-e5d6-9ddd-03f0-abe95569a6f2@kernel.org> Date: Thu, 28 Nov 2019 15:17:20 +1100 Message-ID: <874kyo1vov.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org writes: >> -----Original Message----- >> From: linux-kselftest-owner@vger.kernel.org [mailto:linux-kselftest- >> owner@vger.kernel.org] On Behalf Of shuah >> Sent: Wednesday, November 27, 2019 5:33 PM >> To: Cristian Marussi ; Michael Ellerman >> ; Bird, Tim ; linux- >> kselftest@vger.kernel.org; shuah >> Subject: Re: kselftest: failed to build with -C tool/testing/selftests when >> KBUILD_OUTPUT is set >> >> On 11/27/19 9:53 AM, Cristian Marussi wrote: ... >> > Well I'm not sure if it covers all the build cases/scenario for CIs and I have >> > only verified that this specific failure seems to work using the toplevel Makefile >> > targets (since the offending commit uses abs-objtree). >> > Anyway $ ./kselftest_install.sh is broken too as of now. >> >> With the revert, it will go back to not having support for relative >> paths :( >> >> I will look into reverting the offending commit or fixing it. > > There may not be many people using relative paths for KBUILD_OUTPUT. > I was affected by it, and it's quite handy given some of the mechanisms in > my CI system, but it's not that hard to work around. (That is, I can just > convert relative paths to absolute paths in a few key places in my > CI, before calling the kernel make.) > > Given that I'm the only person (seemingly) who reported this, and I'm ok > working around it, I think a revert is OK for now. I think that would be best at this stage, every day this is unfixed is another day that selftests aren't getting built and tested. It should just be a matter of passing your output directory to `realpath` somewhere in your script. cheers