From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80AB2C433FE for ; Thu, 10 Nov 2022 15:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231545AbiKJPag (ORCPT ); Thu, 10 Nov 2022 10:30:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231566AbiKJPaF (ORCPT ); Thu, 10 Nov 2022 10:30:05 -0500 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 911033E0A5; Thu, 10 Nov 2022 07:28:45 -0800 (PST) Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id CAEBB37E; Thu, 10 Nov 2022 15:28:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net CAEBB37E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1668094125; bh=va/Z2qTnKDsS1pdWrOu4QNjUZp+uTSMAsg5VDdjhRBw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=k8ooLvHEZHXZcS51FQG4xMfADuPWslODvMX/f/4wEga9Bvypx0oMYHBQ1EiaCK1d6 D2syrbMLyZcRBbHkxV+PPXKKW8acTps/lKIZ73ggihYIOvD2jHYdO6sjdUv14p+cnt UT6ArCqJx10lhx6+adX+5aFowvzxzQIl+PtFGAfTR8TR/aibG6+QvL+haLtjBq4avs Va5HG5xs/dfznaoYCdS1hLgt6h+eWGhpkISkrGFFydHb2SKEFN8GGv7k7dhe8P79Mg eCt6r7OenGwQzz0kWBI7t5CoXu+NGlLLpsw+div8dKzt5LTS3ZPL8Tn30porIQN0T9 ZhyyDKwAGFp9w== From: Jonathan Corbet To: Jason Gunthorpe Cc: Bagas Sanjaya , bpf@vger.kernel.org, David Woodhouse , iommu@lists.linux.dev, Joerg Roedel , Kevin Tian , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , Robin Murphy , Shuah Khan , Suravee Suthikulpanit , Tom Rix , Will Deacon , Alex Williamson , Lu Baolu , Chaitanya Kulkarni , Cornelia Huck , Daniel Jordan , David Gibson , Eric Auger , Eric Farman , Jason Wang , Jean-Philippe Brucker , Joao Martins , kvm@vger.kernel.org, Matthew Rosato , "Michael S. Tsirkin" , Nicolin Chen , Niklas Schnelle , Shameerali Kolothum Thodi , Yi Liu , Keqian Zhu Subject: Re: [PATCH v4 04/17] iommufd: Document overview of iommufd In-Reply-To: References: <0-v4-0de2f6c78ed0+9d1-iommufd_jgg@nvidia.com> <4-v4-0de2f6c78ed0+9d1-iommufd_jgg@nvidia.com> <87v8nmhnkl.fsf@meer.lwn.net> <87r0yahmlg.fsf@meer.lwn.net> Date: Thu, 10 Nov 2022 08:28:44 -0700 Message-ID: <87mt8yhlqr.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Jason Gunthorpe writes: > On Thu, Nov 10, 2022 at 08:10:19AM -0700, Jonathan Corbet wrote: >> Jason Gunthorpe writes: >> >> > On Thu, Nov 10, 2022 at 07:49:14AM -0700, Jonathan Corbet wrote: >> > >> >> The *real* problem, methinks, is that the directives are added in patch 4 >> >> of the series, but the documentation doesn't show up until later. So >> >> the real fix would be to simply move this patch down. Or just not worry >> >> about it, since it all works out in the end and nobody will be bisecting >> >> a docs build. >> > >> > That is half the problem, the other is this: >> > >> > https://lore.kernel.org/r/0-v1-c80e152ce63b+12-kdoc_export_ns_jgg@nvidia.com >> > >> > Since even after the whole series the EXPORT_NS functions don't parse >> > properly. I'm going to put this patch before the doc patch and ignore >> > the bisection problem. >> > >> > I'd like someone to say they are happy with the perl :) >> >> I'm not happy with *any* perl! :) >> >> I've been sitting on that patch because I was under the impression >> another version was coming - was that wrong? > > I can resend it with the single regex if that is the preference - it > is not quite as exacting as the first version. I have to test it is > all. Single is nicer but it's not worth a great deal of angst; nothing we do is going to turn kernel-doc into a thing of beauty :) Thanks, jon