From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D842C4360C for ; Thu, 10 Oct 2019 15:22:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C43321835 for ; Thu, 10 Oct 2019 15:22:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725959AbfJJPWl (ORCPT ); Thu, 10 Oct 2019 11:22:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60250 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfJJPWl (ORCPT ); Thu, 10 Oct 2019 11:22:41 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF41110C0936; Thu, 10 Oct 2019 15:22:40 +0000 (UTC) Received: from oldenburg2.str.redhat.com (dhcp-192-200.str.redhat.com [10.33.192.200]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DBD731001B36; Thu, 10 Oct 2019 15:22:31 +0000 (UTC) From: Florian Weimer To: Christian Brauner Cc: linux-kernel@vger.kernel.org, Oleg Nesterov , libc-alpha@sourceware.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Shuah Khan , Andrew Morton , Michal Hocko , Elena Reshetova , Thomas Gleixner , Roman Gushchin , Andrea Arcangeli , Al Viro , Aleksa Sarai , "Dmitry V. Levin" , linux-kselftest@vger.kernel.org Subject: Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND References: <20191010133518.5420-1-christian.brauner@ubuntu.com> <87d0f4of7j.fsf@oldenburg2.str.redhat.com> <20191010152148.gdea35mi7s6ivev6@wittgenstein> Date: Thu, 10 Oct 2019 17:22:30 +0200 In-Reply-To: <20191010152148.gdea35mi7s6ivev6@wittgenstein> (Christian Brauner's message of "Thu, 10 Oct 2019 17:21:49 +0200") Message-ID: <87tv8gmxqh.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Thu, 10 Oct 2019 15:22:41 +0000 (UTC) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org * Christian Brauner: > On Thu, Oct 10, 2019 at 04:19:44PM +0200, Florian Weimer wrote: >> * Christian Brauner: >> >> > @@ -2567,7 +2572,7 @@ static bool clone3_args_valid(const struct kernel_clone_args *kargs) >> > * All lower bits of the flag word are taken. >> > * Verify that no other unknown flags are passed along. >> > */ >> > - if (kargs->flags & ~CLONE_LEGACY_FLAGS) >> > + if (kargs->flags & ~(CLONE_LEGACY_FLAGS | CLONE3_CLEAR_SIGHAND)) >> > return false; >> >> Does the comment need updating? I feel it's a bit misleading now. > > Yeah, maybe just: > > /* Verify that no unknown flags are passed along. */ > > ? Sure, looks fine to me. Thanks, Florian