linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Jerome Glisse <jglisse@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Keith Busch <keith.busch@intel.com>,
	LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 1/1] mm/gup_benchmark: fix MAP_HUGETLB case
Date: Tue, 22 Oct 2019 12:39:53 -0700	[thread overview]
Message-ID: <8892a2be-029b-f8c5-d984-8ff3b5c490ed@nvidia.com> (raw)
In-Reply-To: <20191022185701.GD5169@redhat.com>

On 10/22/19 11:57 AM, Jerome Glisse wrote:
> On Tue, Oct 22, 2019 at 11:41:57AM -0700, John Hubbard wrote:
>> On 10/22/19 10:14 AM, Jerome Glisse wrote:
>>> On Mon, Oct 21, 2019 at 02:24:35PM -0700, John Hubbard wrote:
>>>> The MAP_HUGETLB ("-H" option) of gup_benchmark fails:
>> ...
> So i was misslead by the file descriptor, passing a file descriptor and
> asking for anonymous always bugs me. But yeah the _linux_ kernel is happy
> to ignore the file argument if you set the anonymous flag. I guess the
> rules of passing -1 for fd when anonymous is just engrave in my brain.
> 

Yeah, I definitely get that. In fact, I initially considered further changing 
the test code so as to pass -1 for fd in this case, but because it's pure 
Linux-only test code, it didn't really seem worth the (small) additional
change.

> Also i thought that the file was an argument of the test and thus that
> for huge you needed to pass a hugetlbfs' file.
> 
> Anyway my mistake, you are right, you can pass a file and ask for anonymous
> and hugetlb at the same time.
> 
> Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
> 

Thanks for the review! 

Admin note: this already went into mmotm, so I'm hoping Andrew will notice this
email and add the Reviewed-by tag, please?

thanks,

John Hubbard
NVIDIA

  reply	other threads:[~2019-10-22 19:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 21:24 [PATCH 0/1] " John Hubbard
2019-10-21 21:24 ` [PATCH 1/1] " John Hubbard
2019-10-22 17:14   ` Jerome Glisse
2019-10-22 18:41     ` John Hubbard
2019-10-22 18:57       ` Jerome Glisse
2019-10-22 19:39         ` John Hubbard [this message]
2019-10-22 21:34           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8892a2be-029b-f8c5-d984-8ff3b5c490ed@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=jglisse@redhat.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --subject='Re: [PATCH 1/1] mm/gup_benchmark: fix MAP_HUGETLB case' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).