From: shuah <shuah@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Cristian Marussi <cristian.marussi@arm.com>,
Tim.Bird@sony.com,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>, shuah <shuah@kernel.org>
Subject: Re: kselftest: failed to build with -C tool/testing/selftests when KBUILD_OUTPUT is set
Date: Thu, 28 Nov 2019 16:33:01 -0700 [thread overview]
Message-ID: <8b453a07-68c1-2f6e-eb58-e25d437d28ff@kernel.org> (raw)
In-Reply-To: <871rts1vjx.fsf@mpe.ellerman.id.au>
On 11/27/19 9:20 PM, Michael Ellerman wrote:
> shuah <shuah@kernel.org> writes:
>> On 11/27/19 9:23 AM, Cristian Marussi wrote:
>>> On 27/11/2019 16:04, shuah wrote:
>>>>> On 27/11/2019 03:54, Michael Ellerman wrote:
> ...
>>>>>>
>>>>>> It just hit my travis jobs when I merged up to master:
>>>>>>
>>>>>> https://travis-ci.org/linuxppc/linux/jobs/617482001
>>>>>>
>>>>>> Shuah can we please get this reverted?
>>>>>>
>>>>
>>>> I will take care of this. Supporting all these use-cases has been
>>>> maintenance problem. Fixing one use-case breaks another. :(
> ...
>>
>> If all of the above works with kselftest-install target, I would rather
>> ask for CI's to change, so we can get rid of make -C usage for install.
>>
>> In which case, I would rather not revert this and request CIs to start
>> using kselftest-install target.
>>
Okay reverted now and pushed it to linux-kselftest fixes. Will send it
to Linus in a couple of days.
>> I would like to see CI's use kselftest-* targets from the main makefile
>> for build/run/install.
>
> The problem is old kernels (stable branches & distro kernels) don't
> support that (or it doesn't work correctly).
> > So then the CIs have to invoke the selftest build differently depending
> on which kernel version they're building, which gets ugly for them.
>
Let's move there slowly as stables get retired. I would like to see
using kselftest main Makefile files as the supported mode going forward.
This is necessary for us to make it easier to support and maintain the
use-cases.
thanks,
-- Shuah
prev parent reply other threads:[~2019-11-28 23:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 16:33 kselftest: failed to build with -C tool/testing/selftests when KBUILD_OUTPUT is set Cristian Marussi
2019-11-27 3:54 ` Michael Ellerman
2019-11-27 10:54 ` Cristian Marussi
2019-11-27 16:04 ` shuah
2019-11-27 16:23 ` Cristian Marussi
2019-11-27 16:42 ` shuah
2019-11-27 16:53 ` Cristian Marussi
2019-11-27 17:32 ` shuah
2019-11-27 17:57 ` Tim.Bird
2019-11-27 18:16 ` shuah
2019-11-27 18:48 ` Cristian Marussi
2019-11-28 4:17 ` Michael Ellerman
2019-11-28 4:20 ` Michael Ellerman
2019-11-28 23:33 ` shuah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b453a07-68c1-2f6e-eb58-e25d437d28ff@kernel.org \
--to=shuah@kernel.org \
--cc=Tim.Bird@sony.com \
--cc=cristian.marussi@arm.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).