linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Joe Lawrence <joe.lawrence@redhat.com>,
	live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: Jiri Benc <jbenc@redhat.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH v4] selftests/livepatch: add test skip handling
Date: Wed, 24 Jul 2019 14:19:49 -0600	[thread overview]
Message-ID: <92c4941a-e1cc-4933-9cc0-610f9ec349c5@kernel.org> (raw)
In-Reply-To: <20190724200558.6412-1-joe.lawrence@redhat.com>

On 7/24/19 2:05 PM, Joe Lawrence wrote:
> Add a skip() message function that stops the test, logs an explanation,
> and sets the "skip" return code (4).
> 
> Before loading a livepatch self-test kernel module, first verify that
> we've built and installed it by running a 'modprobe --dry-run'.  This
> should catch a few environment issues, including !CONFIG_LIVEPATCH and
> !CONFIG_TEST_LIVEPATCH.  In these cases, exit gracefully with the new
> skip() function.
> 
> Reported-by: Jiri Benc <jbenc@redhat.com>
> Suggested-by: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
> 
> v4: s/unable load/unable to load/ in user visible skip message. [shuah]
> 

Thanks. Applied to linux-ksefktest fixes for 5.3-rc2 with Petr's Ack

thanks,
-- Shuah

  reply	other threads:[~2019-07-24 20:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 14:05 [PATCH v3] selftests/livepatch: add test skip handling Joe Lawrence
2019-07-23 15:53 ` shuah
2019-07-24 20:05   ` [PATCH v4] " Joe Lawrence
2019-07-24 20:19     ` shuah [this message]
2019-07-24  6:27 ` [PATCH v3] " Petr Mladek
2019-07-24 16:45   ` shuah
2019-07-24 18:45     ` Joe Lawrence
2019-07-24 19:51       ` shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92c4941a-e1cc-4933-9cc0-610f9ec349c5@kernel.org \
    --to=shuah@kernel.org \
    --cc=jbenc@redhat.com \
    --cc=joe.lawrence@redhat.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).