From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57313CA9EA0 for ; Tue, 22 Oct 2019 09:50:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34E4221928 for ; Tue, 22 Oct 2019 09:50:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731580AbfJVJuQ (ORCPT ); Tue, 22 Oct 2019 05:50:16 -0400 Received: from [217.140.110.172] ([217.140.110.172]:48102 "EHLO foss.arm.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1731559AbfJVJuQ (ORCPT ); Tue, 22 Oct 2019 05:50:16 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EB1E1FB; Tue, 22 Oct 2019 02:49:51 -0700 (PDT) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B50353F718; Tue, 22 Oct 2019 02:49:50 -0700 (PDT) Subject: Re: [PATCH] kselftest: Fix NULL INSTALL_PATH for TARGETS runlist To: Prabhakar Kushwaha Cc: linux-kselftest@vger.kernel.org, Shuah Khan , Prabhakar Kushwaha References: <20191020122452.3345-1-prabhakar.pkin@gmail.com> <09db8f9d-98b9-e3ae-9eea-ae45e94d3053@arm.com> From: Cristian Marussi Message-ID: <9900c764-5e3f-26c3-d0e6-6fa444724f75@arm.com> Date: Tue, 22 Oct 2019 10:49:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi On 22/10/2019 04:52, Prabhakar Kushwaha wrote: > Dear Cristian, > > On Mon, Oct 21, 2019 at 4:15 PM Cristian Marussi > wrote: >> >> Hi >> >> On 20/10/2019 13:24, Prabhakar Kushwaha wrote: >>> As per commit 131b30c94fbc ("kselftest: exclude failed TARGETS from >>> runlist") failed targets were excluded from the runlist. But value >>> $$INSTALL_PATH is always NULL. It should be $INSTALL_PATH instead >>> $$INSTALL_PATH. >>> >>> So, fix Makefile to use $INSTALL_PATH. >>> >> >> I was a bit puzzled at first since I never saw the NULLified value while testing >> the original patch. Looking at it closely today, I realized that I used to test it >> like: >> >> $ rm -rf $HOME/KSFT_TEST && make -C tools/testing/selftests/ INSTALL_PATH=$HOME/KSFT_TEST install >> >> which in fact causes INSTALL_PATH to be exported down to the subshell in the recipe, so that even >> referring it as $$INSTALL_PATH from the recipe line make it work fine. >> >> Instead, using the default Makefile provided value (unexported) by invoking like: >> >> $ rm -rf $HOME/KSFT_TEST && make -C tools/testing/selftests/ install >> >> exposes the error you mentioned, being INSTALL_PATH not accessible form the subshell and so NULL. >> Moreover it's anyway certainly better to refer with $(INSTALL_PATH) being it a strict Makefile var. >> So it's fine for me, thanks to have spotted this. >> >> Reviewed-by: cristian.marussi@arm.com >> > > Thanks for Reviewing. > > I have to send v2 patch with author mail id fix. I will keep your Reviewed-by. Thanks to you. I forgot to say that maybe it's worth also adding a Fixes: tag too like: Fixes: 131b30c94fbc ("kselftest: exclude failed TARGETS from runlist") given that I've spotted the original patch being already picked up for some stable queues like in: https://lore.kernel.org/lkml/20191018220324.8165-22-sashal@kernel.org/ Thanks Cristian > > --prabhakar (pk) > > >> >>> Signed-off-by: Prabhakar Kushwaha >>> Signed-off-by: Prabhakar Kushwaha >>> CC: Cristian Marussi >>> --- >>> tools/testing/selftests/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile >>> index 4cdbae6f4e61..612f6757015d 100644 >>> --- a/tools/testing/selftests/Makefile >>> +++ b/tools/testing/selftests/Makefile >>> @@ -213,7 +213,7 @@ ifdef INSTALL_PATH >>> @# included in the generated runlist. >>> for TARGET in $(TARGETS); do \ >>> BUILD_TARGET=$$BUILD/$$TARGET; \ >>> - [ ! -d $$INSTALL_PATH/$$TARGET ] && echo "Skipping non-existent dir: $$TARGET" && continue; \ >>> + [ ! -d $(INSTALL_PATH)/$$TARGET ] && echo "Skipping non-existent dir: $$TARGET" && continue; \ >>> echo "[ -w /dev/kmsg ] && echo \"kselftest: Running tests in $$TARGET\" >> /dev/kmsg" >> $(ALL_SCRIPT); \ >>> echo "cd $$TARGET" >> $(ALL_SCRIPT); \ >>> echo -n "run_many" >> $(ALL_SCRIPT); \ >>> >>