archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <>
To: David Gow <>,
	Brendan Higgins <>,
	Daniel Latypov <>
Cc:,,, kernel test robot <>,
	Shuah Khan <>
Subject: Re: [PATCH] kunit: Fix merge issue in suite filtering test
Date: Fri, 25 Jun 2021 10:11:29 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 6/25/21 5:16 AM, David Gow wrote:
> There were a couple of errors introuced when
> "kunit: add unit test for filtering suites by names"[1] was merged in
> c9d80ffc5a.
> An erroneous '+' was introduced in executor.c, and the executor_test.c
> file went missing. This causes the kernel to fail to compile if
> CONFIG_KUNIT is enabled, as reported in [2,3].
> As with the original, I've tested by running just the new tests using
> itself:
> $ ./tools/testing/kunit/ run '*exec*'
> [1]:
> [2]:
> [3]:
> Fixes: c9d80ffc5a ("kunit: add unit test for filtering suites by names")
> Reported-by: kernel test robot <>
> Signed-off-by: David Gow <>
> ---
> This is another fix for the kunit-fixes branch, where there seems to
> have been an issue merging the "kunit: add unit test for filtering
> suites by names" patch here:
> Again, feel free to squash this into the original patch if that works
> better.

Thank you. My bad. Applied to kunit-fixes now.


-- Shuah

  reply	other threads:[~2021-06-25 16:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 11:16 [PATCH] kunit: Fix merge issue in suite filtering test David Gow
2021-06-25 16:11 ` Shuah Khan [this message]
2021-06-25 17:08   ` Daniel Latypov
2021-06-25 17:24     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).